From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54993: 28.1; Editing etc/NEWS on master with Emacs 28 signals an error Date: Mon, 18 Apr 2022 17:15:42 +0300 Message-ID: <835yn6wk8h.fsf@gnu.org> References: <83czhfy583.fsf@gnu.org> <87mtgj7dxa.fsf@gnus.org> <8335iby288.fsf@gnu.org> <87a6cj7d75.fsf@gnus.org> <83v8v7wmgh.fsf@gnu.org> <878rs2dbtn.fsf@gmx.de> <83ee1uwxl5.fsf@gnu.org> <87v8v6bt5v.fsf@gmx.de> <837d7mwtzj.fsf@gnu.org> <87tuaqir1c.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24757"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, 54993@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 18 16:17:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngSBl-0005vX-6r for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Apr 2022 16:17:13 +0200 Original-Received: from localhost ([::1]:44682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngSBj-0008FK-Mx for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Apr 2022 10:17:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngSBa-0008FA-8B for bug-gnu-emacs@gnu.org; Mon, 18 Apr 2022 10:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46460) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ngSBZ-0002x2-VP for bug-gnu-emacs@gnu.org; Mon, 18 Apr 2022 10:17:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ngSBZ-0000B6-Ow for bug-gnu-emacs@gnu.org; Mon, 18 Apr 2022 10:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Apr 2022 14:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54993 X-GNU-PR-Package: emacs Original-Received: via spool by 54993-submit@debbugs.gnu.org id=B54993.1650291369604 (code B ref 54993); Mon, 18 Apr 2022 14:17:01 +0000 Original-Received: (at 54993) by debbugs.gnu.org; 18 Apr 2022 14:16:09 +0000 Original-Received: from localhost ([127.0.0.1]:40357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngSAi-00009f-KA for submit@debbugs.gnu.org; Mon, 18 Apr 2022 10:16:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ngSAg-00009B-LU for 54993@debbugs.gnu.org; Mon, 18 Apr 2022 10:16:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43828) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngSAa-0002o2-8F; Mon, 18 Apr 2022 10:16:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Qc0teiTH/IpzJGG/hu86KYK4dp/0PzHnTHSpslQxrDU=; b=AP7uJFBus3js mC2DlQQj+Dd3PP/Ro4utbrfcHLT7NGR38iNK89ln64b8Q7RB55Orzq54xEhDHhLOID2K2ELEI6wpP Lh3yght3rYGJLtambEaZGWysP20Eq1ALIJKEkACua8110i5wuEUtpdDu9sRIIdJ/Auc/DEy81DIn/ eaKibasul9FTEFdBs6ZpGUikxA7KPLjs13T6x44G2inEsk/Pn9k8YOebtjwGH4h3sfRGReczcdB1A /6NBdauiXudQUj7XHnW0av0AD7MTEyefFw1a6i7J3aZq2qUfpmV7oT7haStUR52jjzKTbk8h8utVe Xc554NoeY6W3WgrHN2782g==; Original-Received: from [87.69.77.57] (port=2179 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngSAU-0007PB-Tg; Mon, 18 Apr 2022 10:15:59 -0400 In-Reply-To: <87tuaqir1c.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 18 Apr 2022 13:12:31 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230182 Archived-At: > From: Lars Ingebrigtsen > Cc: Michael Albinus , 54993@debbugs.gnu.org > Date: Mon, 18 Apr 2022 13:12:31 +0200 > > Eli Zaretskii writes: > > > We could add NEWS to auto-mode-alist instead, and that would solve the > > issue cleanly for everyone. That was one of the original > > alternatives, but somehow it was forgotten now. > > My worry with that was that adding etc/NEWS to auto-mode-alist would be > false positives (for other files with that name). But I guess we could > check that it's actually an Emacs NEWS file before enabling the mode. I looked at several NEWS files in various projects, and they look well under outline mode. Which doesn't really surprise me, since NEWS is AFAIR a GNU thing. > But that would mean removing the mode: setting from NEWS itself, because > mode: takes precedence over auto-mode-alist, I think? Yes. > So then we're back to people editing the file in Emacs 28 in > fundamental-mode. Yes. So maybe instead Outline mode in Emacs 29 could turn on emacs-news-mode automatically when the file's name is NEWS or NEWS.* or ONEWS. > > Btw, another issue with emacs-news-mode is that it invokes > > outline-minor-mode, which means all the headings-related commands are > > now bound to different keys than they were before. Wouldn't it be > > better if emacs-news-mode were a minor mode invoked by Outline > > instead? > > emacs-news-mode is quite major-modeish, though, so I think that would be > awkward. I don't see why. What do you see in emacs-news-mode that doesn't fit a minor mode? I guess my point is that making it a major mode makes this a backward-incompatible change, when we consider editing of NEWS. If we can avoid that, it would be better. Or maybe it's enough to make it be derived from Outline (if that doesn't interfere with editing NEWS with older Emacsen)?