all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org, yantar92@gmail.com
Subject: Re: master 979308b4ca 5/9: org-export-data: Concatenate strings in temporary buffer for performance
Date: Thu, 16 Jun 2022 15:53:25 +0300	[thread overview]
Message-ID: <835yl0rcqi.fsf@gnu.org> (raw)
In-Reply-To: <jwva6aczts1.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Thu, 16 Jun 2022 08:19:33 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Ihor Radchenko <yantar92@gmail.com>
> Date: Thu, 16 Jun 2022 08:19:33 -0400
> 
> Eli Zaretskii [2022-06-16 04:09:44] wrote:
> >     org-export-data: Concatenate strings in temporary buffer for performance
> >     
> >     * lisp/org/ox.el (org-export-data): Use temporary buffer to collect export
> >     data instead of `mapconcat'.  Using buffer puts less load on garbage
> >     collector.
> 
> AFAICT this just replaces `mapconcat` with a `with-temp-buffer + dolist
> + insert`, so if this makes a significant performance difference, it
> points to a performance problem in our `mapconcat`, right?

I didn't test each of the changes separately, so I don't know.



      parent reply	other threads:[~2022-06-16 12:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165536698076.5328.17316430648307086249@vcs2.savannah.gnu.org>
     [not found] ` <20220616080945.7DD14C01685@vcs2.savannah.gnu.org>
2022-06-16 12:19   ` master 979308b4ca 5/9: org-export-data: Concatenate strings in temporary buffer for performance Stefan Monnier
2022-06-16 12:45     ` Lars Ingebrigtsen
2022-06-16 13:33       ` Robert Pluim
2022-06-16 12:49     ` Ihor Radchenko
2022-06-16 17:43       ` Stefan Monnier
2022-06-17 11:35         ` Ihor Radchenko
2022-06-16 12:53     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835yl0rcqi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.