From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry Date: Fri, 18 Nov 2022 16:16:37 +0200 Message-ID: <835yfcbb5m.fsf@gnu.org> References: <87tu2wlku7.fsf@elite.giraud> <83r0y0biad.fsf@gnu.org> <87leo8wjee.fsf@elite.giraud> <83fsegbg94.fsf@gnu.org> <874juwwggd.fsf@elite.giraud> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17334"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59351@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 18 15:17:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow2BS-0004D6-0K for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Nov 2022 15:17:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow2B8-00075t-FG; Fri, 18 Nov 2022 09:17:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow2Aw-000754-Qg for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 09:17:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow2Aw-0000mC-HY for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 09:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow2Aw-0000nf-DS for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 09:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2022 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59351 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59351-submit@debbugs.gnu.org id=B59351.16687810053048 (code B ref 59351); Fri, 18 Nov 2022 14:17:02 +0000 Original-Received: (at 59351) by debbugs.gnu.org; 18 Nov 2022 14:16:45 +0000 Original-Received: from localhost ([127.0.0.1]:35930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow2Af-0000n6-5Q for submit@debbugs.gnu.org; Fri, 18 Nov 2022 09:16:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow2Ae-0000mv-3c for 59351@debbugs.gnu.org; Fri, 18 Nov 2022 09:16:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow2AY-0000b5-1g; Fri, 18 Nov 2022 09:16:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=28puOmZPLc5IvRqaftcTeHi7lBAeuYBRfWrn4b1fAH0=; b=jiQrublGe3j3 o+hsUbTYllMxCq5MKmvVFHozUSjAbk6bE1lWcqfra9AqcsL1pP2w5EOJ1Wy5SAX1uWXhOPhW7TcQh cg2knNkz2mncNLvywranDYrYm6fRyPkOjj6eTgkNEFMPnGXwvxebQXy6YoY4inI7ca8Dz3no3Bua2 wR+QZWi15XxWVfR7lRv3/mQIDLjcb6CJBMKpJrrK9YDHZy5xuFq0Fnr7bBgVwcQIhWZHMh3CcAG9D tfqGHyvYr+Hiao0OpGx9sz+eaquqCkV3Q80zO2E5vVsH+Izrh0sacH51t0G0Sv23xSwRQ8IlWbTq6 IHtItDe/v6qdE4V3WHfHuA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow2AU-0004w5-Db; Fri, 18 Nov 2022 09:16:37 -0500 In-Reply-To: <874juwwggd.fsf@elite.giraud> (message from Manuel Giraud on Fri, 18 Nov 2022 14:16:34 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248242 Archived-At: > From: Manuel Giraud > Cc: 59351@debbugs.gnu.org > Date: Fri, 18 Nov 2022 14:16:34 +0100 > > > display_menu_bar is supposed to update the metrics of the menu-bar > > line, see the call to compute_line_metrics at its end. Why doesn't it > > happen? > > Yes but it seems that this updating does not take place when the menu > face is changed (not the whole frame face, though: this does work). And > the menu face, when changed, is displayed correctly, but the height of > the window is not modified accordingly. You mean, display_menu_bar is not called in that case? If that is the problem, we should look into the reason. Perhaps some condition is missing for when display_menu_bar is called from redisplay_window.