From: Eli Zaretskii <eliz@gnu.org>
To: lux <lx@shellcodes.org>
Cc: 59544@debbugs.gnu.org, stefankangas@gmail.com
Subject: bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability
Date: Sat, 26 Nov 2022 14:28:22 +0200 [thread overview]
Message-ID: <835yf1ucgp.fsf@gnu.org> (raw)
In-Reply-To: <tencent_A9399566146BF66A0CEFAEE4B3C285839109@qq.com> (message from lux on Sat, 26 Nov 2022 18:41:22 +0800)
> Date: Sat, 26 Nov 2022 18:41:22 +0800
> Cc: 59544@debbugs.gnu.org
> From: lux <lx@shellcodes.org>
>
> > We've lived with this "security issue" for decades, so I see nothing here that justifies
> > "ASAP".
> Maybe someone found it, but didn't publish it?
Fixing it will not magically remove the problem from all the Emacs
installations out there, will it? It will only help to people who track the
master branch and rebuild Emacs very frequently on top of that.
So the urgency of fixing it is not measured in hours anyway.
> for example, the lib-src/ntlib.c:
>
> char *
> cuserid (char * s)
> {
> char * name = getlogin ();
> if (s)
> return strcpy (s, name ? name : "");
> return name;
> }
>
> before calling the strcpy function, the memory size of the pointer s is
> not checked, which may destroy the memory space. So, I want to replace
> it with a safe function, any suggestions?
The above function doesn't seem to be called anywhere in Emacs, so making it
better is a waste of energy. It should probably be removed.
next prev parent reply other threads:[~2022-11-26 12:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 15:27 bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability lux
2022-11-24 18:01 ` Eli Zaretskii
2022-11-24 18:12 ` Stefan Kangas
2022-11-24 18:38 ` Eli Zaretskii
2022-11-25 3:45 ` lux
2022-11-25 6:41 ` lux
2022-11-25 7:53 ` Stefan Kangas
2022-11-25 8:38 ` lux
2022-11-25 8:56 ` Stefan Kangas
2022-11-25 12:19 ` Eli Zaretskii
2022-11-25 12:18 ` Eli Zaretskii
2022-11-25 16:02 ` lux
2022-11-26 0:43 ` Stefan Kangas
2022-11-26 2:30 ` lux
2022-11-26 3:09 ` lux
2022-11-26 9:47 ` Stefan Kangas
2022-11-26 10:14 ` Eli Zaretskii
[not found] ` <tencent_A9399566146BF66A0CEFAEE4B3C285839109@qq.com>
2022-11-26 12:28 ` Eli Zaretskii [this message]
2022-11-26 13:03 ` Stefan Kangas
2022-11-26 14:15 ` Eli Zaretskii
[not found] ` <tencent_F5BD82AD38AB67E06AB86AE8EE5EE577C309@qq.com>
2022-11-26 14:30 ` Eli Zaretskii
2022-11-26 13:21 ` Eli Zaretskii
[not found] ` <tencent_63F9E4F0AB6043CE8C198E1AAA9AD9BB1A07@qq.com>
2022-11-26 14:17 ` Eli Zaretskii
[not found] ` <tencent_0B66566A766A94EE00E45DC327831B387709@qq.com>
2022-11-26 14:49 ` Eli Zaretskii
[not found] ` <tencent_B9EE8C5FCD5A8DCF9D8AFC56787AF00AE706@qq.com>
2022-11-26 17:11 ` Eli Zaretskii
2022-11-27 3:05 ` lux
2022-11-27 6:35 ` lux
2022-11-27 14:15 ` Eli Zaretskii
2022-11-27 14:31 ` Eli Zaretskii
[not found] ` <tencent_67B00527E64C548D4ECDF55D977C75B84B06@qq.com>
2022-11-27 18:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835yf1ucgp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59544@debbugs.gnu.org \
--cc=lx@shellcodes.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.