From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability Date: Sat, 26 Nov 2022 19:11:29 +0200 Message-ID: <835yf1skse.fsf@gnu.org> References: <837czkw7sl.fsf@gnu.org> <8335a8w643.fsf@gnu.org> <83fse7ut10.fsf@gnu.org> <83y1rxsvf6.fsf@gnu.org> <83r0xpssto.fsf@gnu.org> <83h6ylsrcb.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5715"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59544@debbugs.gnu.org, stefankangas@gmail.com To: lux Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 26 18:12:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyyj9-0001Iv-2f for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Nov 2022 18:12:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyyim-0002Sf-MV; Sat, 26 Nov 2022 12:12:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyyil-0002Oc-33 for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 12:12:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyyij-0001N3-Nf for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 12:12:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyyig-0002na-J5 for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 12:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 17:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security patch Original-Received: via spool by 59544-submit@debbugs.gnu.org id=B59544.166948267410749 (code B ref 59544); Sat, 26 Nov 2022 17:12:02 +0000 Original-Received: (at 59544) by debbugs.gnu.org; 26 Nov 2022 17:11:14 +0000 Original-Received: from localhost ([127.0.0.1]:41336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyyht-0002nJ-Mj for submit@debbugs.gnu.org; Sat, 26 Nov 2022 12:11:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyyhs-0002nD-2t for 59544@debbugs.gnu.org; Sat, 26 Nov 2022 12:11:13 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyyhl-000171-SS; Sat, 26 Nov 2022 12:11:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=55ykLNWIxVXQfwtbgyBotTN0L7LmDar/SCKR2tYP5lI=; b=YmfyEZv6ScpG gQiBrvKVj2N7siAhQsmepJa3/m3TpTqpl0JPogLQDlTbNyGDCEr+X+CS0W+QDKiMhQ9bxugVRcxFm tusey/KZXfQSJNmXBEa30/QOvcXJqQxzoJoDSJb2KTbphZvbY40f5QqBVDGDw7JawbG5Ne2a0OYMH kpQ9IitXorDxNTokrpf/lfhsBKCk/xumWp+5ClyOQXhxPXgBTZr435LRZt8Sg1ZfkSIy2MYNRD9ro 60SG9lhr6gq+pG8a2cvgR99vXqKHOnmmOyGfTXQYffHAZHUNZ57LCnp9Q7vVrre/iBaMFT/0Kctw8 BTb5dmvY4qXBIZG/41R/Gg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyyhl-0004a9-8a; Sat, 26 Nov 2022 12:11:05 -0500 In-Reply-To: (message from lux on Sun, 27 Nov 2022 01:03:10 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249117 Archived-At: > Date: Sun, 27 Nov 2022 01:03:10 +0800 > Cc: stefankangas@gmail.com, 59544@debbugs.gnu.org > From: lux > > I'm going to add the xxx parameter. If it is true, the line break will > be kept. Is this logic consistent with what you expressed? thank you > very much. Much simpler: static ptrdiff_t readline_internal (linebuffer *lbp, FILE *stream, char const *filename, bool leave_cr) { [...] if (c == '\n') { if (!leave_cr && p > buffer && p[-1] == '\r') { [...] IOW, when this flag is TRUE, don't process \r specially. Thanks.