From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59838: 30.0.50; [PATCH] Save history in GDB session Date: Mon, 05 Dec 2022 21:35:25 +0200 Message-ID: <835yep8wzm.fsf@gnu.org> References: <87o7shhjwt.fsf@ledu-giraud.fr> <837cz593az.fsf@gnu.org> <877cz5hh42.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7054"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59838@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 05 20:37:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2HHD-0001Y5-Va for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Dec 2022 20:37:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2HGz-0002qG-MZ; Mon, 05 Dec 2022 14:37:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2HGw-0002py-U7 for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 14:37:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2HGw-0001sy-D6 for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 14:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2HGw-0000g1-1q for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 14:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59838 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59838-submit@debbugs.gnu.org id=B59838.16702689652587 (code B ref 59838); Mon, 05 Dec 2022 19:37:02 +0000 Original-Received: (at 59838) by debbugs.gnu.org; 5 Dec 2022 19:36:05 +0000 Original-Received: from localhost ([127.0.0.1]:37921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2HG0-0000ff-Uw for submit@debbugs.gnu.org; Mon, 05 Dec 2022 14:36:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2HFy-0000fI-VM for 59838@debbugs.gnu.org; Mon, 05 Dec 2022 14:36:03 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2HFn-0001dq-4w; Mon, 05 Dec 2022 14:35:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7ljjLADAPUFe74upYUbJQID3+9m7bITv87vGJNK8PC0=; b=aRg8gnkihP4E +VH5DqkQ19oP73wIdMuanCOUbOYRh3YaffkZOgj+b+paeORpBL/AWnQLXOS/DKDoiyyccEUHO+mZb amJa70+MLgAJGcnZ4MdSeDgkwLZe7m8PVne8JpxiA+RpSX0gwhnYEDVE3oPBTLvqbf4lYkwDeGJvc hbXTArfl7sNhSI5/2SVosXVRcxl/3cAeDItf3c5LnEsUUQyJnfgRxcRRiTdlBNkskGVNerMdekybC X7PnCN5PPvfn/V9cJSFIr7VJfadafASwk7PRTO92gwi8skh6EkoxHRZNEtX5lcqBvIP0iVGBAhRQH SuaHrxJgl2evLuf+cDRZ7A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2HFd-0005aj-MG; Mon, 05 Dec 2022 14:35:49 -0500 In-Reply-To: <877cz5hh42.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 05 Dec 2022 18:53:33 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250057 Archived-At: > From: Manuel Giraud > Cc: 59838@debbugs.gnu.org > Date: Mon, 05 Dec 2022 18:53:33 +0100 > > Eli Zaretskii writes: > > >> From: Manuel Giraud > >> Date: Mon, 05 Dec 2022 17:53:06 +0100 > >> > >> I'm not really an expert in gdb (and comint-mode) but it seems that 'M-x > >> gdb' does not save its history. Here is a patch that fix this. > > > > GDB has its own history feature, activated by the GDB command "set history > > save on". If the GDB history file is detected when "M-x gdb" starts, it > > will read the history and fill comint-input-ring with what it finds there. > > See the function 'gdb' in gdb-mi.el. > > > > So I think this is already covered, or what did I miss? > > I already have this in my ~/.gdbinit: > --8<---------------cut here---------------start------------->8--- > set history save on > set history size 1024 > add-auto-load-safe-path /home/manuel/emacs-repo/src/.gdbinit > --8<---------------cut here---------------end--------------->8--- > > When debugging emacs from 'M-x gdb', gdb does create a file > "/home/manuel/emacs-repo/src/.gdb_history" but it always stays empty > even when I "quit" from the *gud-emacs* buffer. I guess this is because GDB's history works via Readline, and Readline is not used when Emacs is the front end. Then I think your patch is correct, thanks.