From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60146: file-exists-in-trash-p needs better name or semantics Date: Sat, 17 Dec 2022 22:09:43 +0200 Message-ID: <835ye9hjw8.fsf@gnu.org> References: <83a63mifgu.fsf@gnu.org> <4b872c57-99fd-dc8c-a121-7f19be0f9d49@cs.ucla.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37768"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 60146@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 17 21:10:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6dVi-0009dO-Um for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Dec 2022 21:10:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6dVU-0002gK-F5; Sat, 17 Dec 2022 15:10:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6dVS-0002fu-Nu for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 15:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6dVS-0003yF-A9 for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 15:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6dVR-0001CY-Lz for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 15:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 20:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60146 X-GNU-PR-Package: emacs Original-Received: via spool by 60146-submit@debbugs.gnu.org id=B60146.16713077884607 (code B ref 60146); Sat, 17 Dec 2022 20:10:01 +0000 Original-Received: (at 60146) by debbugs.gnu.org; 17 Dec 2022 20:09:48 +0000 Original-Received: from localhost ([127.0.0.1]:57761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6dVD-0001CF-KQ for submit@debbugs.gnu.org; Sat, 17 Dec 2022 15:09:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6dVB-0001C7-O9 for 60146@debbugs.gnu.org; Sat, 17 Dec 2022 15:09:46 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6dV5-0003wD-84; Sat, 17 Dec 2022 15:09:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2xnDiKAQCZYtBuz3K+1FUrtZl1cE5YjPoQOMxyewxm0=; b=MNXklND4X0H9 M+luhGXBia0MGWPTj3BX5FEdDJXGIq1rsf0Sm+JIjDoEZ7PW/IolLSpgC4k4RP7+KiqKDBGeX4IgS sYWLBOfwfAJgEmeiTu5pnt16KTYEzHDPAVXCG2I9TZD1auO1zSKFuvA6b238UBiJY2IgKkC0l48QL XJtgT7re1QnRzf2XQ8rYzZbcA/EqHMKa/4bEGVAC7GYvX8UoerhAQTbmJW1OLn6pZrgOdyjed5bxX 9AozEDCg9QDDnGZZttU9tjeIz5L9wJ312ZcIbIBEpGMfEbP14udvtiuDm9qLc5Db1j5U+I+meHYRL aTKtAHGHlqSzvcm2BjdmWw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6dV4-0005MM-OR; Sat, 17 Dec 2022 15:09:39 -0500 In-Reply-To: <4b872c57-99fd-dc8c-a121-7f19be0f9d49@cs.ucla.edu> (message from Paul Eggert on Sat, 17 Dec 2022 11:57:39 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251311 Archived-At: > Date: Sat, 17 Dec 2022 11:57:39 -0800 > Cc: 60146@debbugs.gnu.org > From: Paul Eggert > > I have a bit of a different take. First, there's adequate functionality > in Emacs now if we don't mind inefficiency, and it's already used; just > call file-attributes. (Gnus does this, in nnmaildir-unlink at least, and > I expect there are other uses.) Second, I wouldn't be surprised if other > uses of file-exists-p have problems similar to the one you found in > move-file-to-trash. Not that any of us have time to go scout for them > right now. > > It's a minor point. Still, the name file-exists-in-trash-p really needs > to go somehow as it's not a name that should be user-visible. How about > the attached patch? If you can verify that it works in the scenario of bug#59986, I'm okay with this change.