From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60580: 29.0.60; crash in xdisp.c with modus theme and display-fill-column-indicator Date: Fri, 06 Jan 2023 09:12:17 +0200 Message-ID: <835ydkw2zy.fsf@gnu.org> References: <83h6x4wy8c.fsf@gnu.org> <83fscowxy3.fsf@gnu.org> <87wn60pb0e.fsf@protesilaos.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25816"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yandros@gmail.com, 60580@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 06 08:13:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDgui-0006U7-1u for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Jan 2023 08:13:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDgua-0002As-KO; Fri, 06 Jan 2023 02:13:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDguU-00028O-Tu for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2023 02:13:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDguU-0000ct-MB for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2023 02:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDguU-00033V-GN for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2023 02:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2023 07:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60580 X-GNU-PR-Package: emacs Original-Received: via spool by 60580-submit@debbugs.gnu.org id=B60580.167298913011653 (code B ref 60580); Fri, 06 Jan 2023 07:13:02 +0000 Original-Received: (at 60580) by debbugs.gnu.org; 6 Jan 2023 07:12:10 +0000 Original-Received: from localhost ([127.0.0.1]:53645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDgte-00031t-3s for submit@debbugs.gnu.org; Fri, 06 Jan 2023 02:12:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDgtb-00031d-NE for 60580@debbugs.gnu.org; Fri, 06 Jan 2023 02:12:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDgtV-0000Uu-4l; Fri, 06 Jan 2023 02:12:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/uMJlF68r20AOgIPKBNCwW8vCHtvc8EGgqJkunEDXJU=; b=OMWgasSbcFW/ 67upWfU7fa46KBC3Ly6iqhEc43pnR1s/sWQrRnfVs82AY4eXwjooN72C3m6JW+X4KSzUZI90MzgEl UDc4f2C3TM207qbaaRbdNI2sHcm1QVL6o0N2dVWwKByD+GxZfjfnvlj5A2SUR3iqg2XKNyWXFxAmh Idd+HNVx//x9h4b2hu3wnya2zuNl78+SCPQYMdG/ZKiKrv+xr0w6d/KtEv3QCkHY8egu27bBC9t16 KWkq6t1M9St+r+I4TWJsN4ajbTOm8IBqCC3Gm0qbah2Z06YRMoo+t2PDsi27OZAj3riddrcuH4nuC vIsK4IhEjViqLWOM4ZWBPQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDgtU-0006Zr-EL; Fri, 06 Jan 2023 02:12:00 -0500 In-Reply-To: <87wn60pb0e.fsf@protesilaos.com> (message from Protesilaos Stavrou on Fri, 06 Jan 2023 06:01:05 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252665 Archived-At: > From: Protesilaos Stavrou > Cc: 60580@debbugs.gnu.org > Date: Fri, 06 Jan 2023 06:01:05 +0200 > > > ;;;;; display-fill-column-indicator-mode > > `(fill-column-indicator ((,class :height 1 :background ,bg-region :foreground ,bg-region))) > > > > I have no idea what is ":height 1" about, but I think it's wrong and > > should be replaced with some reasonable value. > > The ":height 1" has been there for many versions and never caused a > problem of this sort. I'm guessing that this is because almost no one builds Emacs with the assertions enabled (--enable-testing=yes at configure time). I do, but the problem doesn't happen on my system, so I haven't seen it, either. > The reason it is like this is to make the indicator a contiguous > line that is not affected by variations in font heights and/or a high > 'line-spacing' value. Otherwise the indicator can appear as a dashed > line. Why do you assume that ":height 1" will avoid this problem? I think you are just using some undocumented side effect of the implementation, as there's no reason to believe using such small height of the face can solve the problem with occasional 1-pixel gaps in the fill-column indicator. But let's first see if my latest changes prevent the assertion violations even without changing the themed faces.