Enlarge dumped_data[]

Enlarge dumped_data[]

[Po Lu]

The MS Windows build fails to dump, telling me to enlarge the
dumped_data[] array.

I find it hard to believe that loadup now generates more than 13 MB.
Is there a bug here, or is Emacs really so big now.

Re: Enlarge dumped_data[]

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Date: Wed, 25 Jan 2023 08:32:57 +0800
> 
> The MS Windows build fails to dump, telling me to enlarge the
> dumped_data[] array.
> 
> I find it hard to believe that loadup now generates more than 13 MB.
> Is there a bug here, or is Emacs really so big now.

Is this during bootstrap or during a "regular" build that has just a
few of the preloaded *.el that need to be byte-compiled, and the rest
already have up-to-date *.elc files?

The 64-bit unexec build on GNU/Linux reports about 21MB of static heap
used up, and that with only a few *.el files, the rest *.elc.  So I
think 13MB on Windows is not outrageous.  I'm okay with increasing the
value, especially since most builds will be unaffected anyway.

Re: Enlarge dumped_data[]

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> Is this during bootstrap or during a "regular" build that has just a
> few of the preloaded *.el that need to be byte-compiled, and the rest
> already have up-to-date *.elc files?

During bootstrap, yes, but it also happened on a regular build before I
tried bootstrapping.

> The 64-bit unexec build on GNU/Linux reports about 21MB of static heap
> used up, and that with only a few *.el files, the rest *.elc.  So I
> think 13MB on Windows is not outrageous.  I'm okay with increasing the
> value, especially since most builds will be unaffected anyway.

Okay, should the adjustment be made on emacs-29 or master?

Re: Enlarge dumped_data[]

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Wed, 25 Jan 2023 20:14:06 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > The 64-bit unexec build on GNU/Linux reports about 21MB of static heap
> > used up, and that with only a few *.el files, the rest *.elc.  So I
> > think 13MB on Windows is not outrageous.  I'm okay with increasing the
> > value, especially since most builds will be unaffected anyway.
> 
> Okay, should the adjustment be made on emacs-29 or master?

If you see the problem on emacs-29, please install the change there.
If it happens only on master, please install on master.

Re: Enlarge dumped_data[]

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> If you see the problem on emacs-29, please install the change there.

I haven't built Emacs 29 on that (new) machine yet, I will do that
tomorrow and ack.  Thanks.

Re: Enlarge dumped_data[]

[Po Lu]

Po Lu <luangruo@yahoo.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> If you see the problem on emacs-29, please install the change there.
>
> I haven't built Emacs 29 on that (new) machine yet, I will do that
> tomorrow and ack.  Thanks.

Now Emacs dumps correctly if preloaded Lisp has been compiled to
bytecode, but it needs an outrageous 40 megabytes to dump
bootstrap-emacs during bootstrap, so that still fails.

What changed recently so as to require so much memory?

Re: Enlarge dumped_data[]

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 26 Jan 2023 09:14:13 +0800
> 
> Po Lu <luangruo@yahoo.com> writes:
> 
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> >> If you see the problem on emacs-29, please install the change there.
> >
> > I haven't built Emacs 29 on that (new) machine yet, I will do that
> > tomorrow and ack.  Thanks.
> 
> Now Emacs dumps correctly if preloaded Lisp has been compiled to
> bytecode, but it needs an outrageous 40 megabytes to dump
> bootstrap-emacs during bootstrap, so that still fails.
> 
> What changed recently so as to require so much memory?

I don't know.  Which branch is that, and when did you last build it
with the old size of dumped_data?

Is this a 32-bit build --with-wide-int or without it?  More generally,
what is the configuration?

Re: Enlarge dumped_data[]

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Po Lu <luangruo@yahoo.com>
>> Cc: emacs-devel@gnu.org
>> Date: Thu, 26 Jan 2023 09:14:13 +0800
>> 
>> Po Lu <luangruo@yahoo.com> writes:
>> 
>> > Eli Zaretskii <eliz@gnu.org> writes:
>> >
>> >> If you see the problem on emacs-29, please install the change there.
>> >
>> > I haven't built Emacs 29 on that (new) machine yet, I will do that
>> > tomorrow and ack.  Thanks.
>> 
>> Now Emacs dumps correctly if preloaded Lisp has been compiled to
>> bytecode, but it needs an outrageous 40 megabytes to dump
>> bootstrap-emacs during bootstrap, so that still fails.
>> 
>> What changed recently so as to require so much memory?
>
> I don't know.  Which branch is that, and when did you last build it
> with the old size of dumped_data?

It worked when I built it around a week ago.  It's the master branch,
emacs-29 builds fine.

> Is this a 32-bit build --with-wide-int or without it?  More generally,
> what is the configuration?

It's a 32 bit build without wide int, and with libXpm and gnutls (both
from ezwinports.)

The system on which Emacs is being built identifies itself as "Windows
XP Service Pack 3".

Re: Enlarge dumped_data[]

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 26 Jan 2023 17:54:17 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Now Emacs dumps correctly if preloaded Lisp has been compiled to
> >> bytecode, but it needs an outrageous 40 megabytes to dump
> >> bootstrap-emacs during bootstrap, so that still fails.
> >> 
> >> What changed recently so as to require so much memory?
> >
> > I don't know.  Which branch is that, and when did you last build it
> > with the old size of dumped_data?
> 
> It worked when I built it around a week ago.  It's the master branch,
> emacs-29 builds fine.

Strange.  I don't see any obvious candidate.  Suggest to bisect.  From
12 MB to 40 MB sounds a lot to me, I cannot even begin to think what
kind of change could cause that.  Did anything change on your build
system since then?  Did you move the source tree to a different place,
perhaps (file names are recorded in the dumped data, so if file names
are longer, you will need more data).

Re: Enlarge dumped_data[]

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> Strange.  I don't see any obvious candidate.  Suggest to bisect.  From
> 12 MB to 40 MB sounds a lot to me, I cannot even begin to think what
> kind of change could cause that.  Did anything change on your build
> system since then?  Did you move the source tree to a different place,
> perhaps (file names are recorded in the dumped data, so if file names
> are longer, you will need more data).

No, nothing changed on that machine.

Does the unexec build work for you, BTW?

Re: Enlarge dumped_data[]

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 26 Jan 2023 19:44:42 +0800
> 
> Does the unexec build work for you, BTW?

On Windows?  I didn't try, not for a long time.

On GNU/Linux I build unexec regularly, and it worked the last time I
tried, when you first reported the problem with dumped_data.

Re: Enlarge dumped_data[]

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

> On GNU/Linux I build unexec regularly, and it worked the last time I
> tried, when you first reported the problem with dumped_data.

It does work on GNU/Linux, yes.  I just did a bootstrap, which reported
that 23222080 bytes were used.

Hmm.  I suspect this could be a machine specific problem.
Maybe rebooting will solve that.