From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60953: The :match predicate with large regexp in tree-sitter font-lock seems inefficient Date: Thu, 02 Feb 2023 08:34:16 +0200 Message-ID: <835yckzic7.fsf@gnu.org> References: <7624dddc-4600-9a03-ac8b-d3c9e0ab618c@yandex.ru> <83wn5ag4nc.fsf@gnu.org> <01b5d074-fb12-6b1f-cbfb-5e759833b854@yandex.ru> <838rhpg57n.fsf@gnu.org> <5026D975-983F-4D18-8690-BE139C92825D@gmail.com> <83pmb1emxi.fsf@gnu.org> <6f318afc-ca71-8b7e-c822-52e6635b5718@yandex.ru> <83sffxcfxw.fsf@gnu.org> <83pmb1cbg5.fsf@gnu.org> <2da844d3-ea31-289e-2821-aa174e365ffd@yandex.ru> <6784f9e7-844b-374d-2a1e-8a61cebe0d7e@yandex.ru> <83zga03yne.fsf@gnu.org> <373a575f-c683-1581-c3e6-502e9897fb04@yandex.ru> <83mt603vrc.fsf@gnu.org> <83e58a1b-2e4a-356a-36d8-c756ff105b62@yandex.ru> <83bkmf52va.fsf@gnu.org> <33cad4c1-4af5-37bb-05bc-79a4d9c1a700@yandex.ru> <83wn533lut.fsf@gnu.org> <19892f55-498e-1109-2229-2ddd984849a4@yandex.ru> <83tu073ksp.fsf@gnu.org> <83sffr2xq2.fsf@gnu.org> <30b047a9-dfe3-948a-a123-2e15221c239d@yandex.ru> <83tu05zeqe.fsf@gnu.org> <957c7e3e-830e-0a03-562f-fdddc6bd1c06@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5254"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 60953@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 02 07:35:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNTBq-0001Ak-3d for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Feb 2023 07:35:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNTBb-0006Hw-4X; Thu, 02 Feb 2023 01:35:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNTBX-0006Ft-H3 for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 01:35:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNTBX-0004Zc-8X for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 01:35:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNTBW-0000e2-Hh for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 01:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 06:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60953 X-GNU-PR-Package: emacs Original-Received: via spool by 60953-submit@debbugs.gnu.org id=B60953.16753196662423 (code B ref 60953); Thu, 02 Feb 2023 06:35:02 +0000 Original-Received: (at 60953) by debbugs.gnu.org; 2 Feb 2023 06:34:26 +0000 Original-Received: from localhost ([127.0.0.1]:60413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNTAv-0000d1-QE for submit@debbugs.gnu.org; Thu, 02 Feb 2023 01:34:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNTAr-0000cn-Vf for 60953@debbugs.gnu.org; Thu, 02 Feb 2023 01:34:24 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNTAm-0003SY-9a; Thu, 02 Feb 2023 01:34:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FQs895Incn6zWM0/+XUNfunRiTuEMmGMa5zqyED8NDA=; b=Y9bwBiNxyHu4 S+wfC87uz3c/2SrDhfTEJ2GZHvTfNAfiljwxrHtLgUSILcGkYm3bNUN2x/qbU2bXyflbxhPm2qlcl sHbtSoXSpj4bkpoUF1cK4ovoHt/6py411lVfLudGYhqirP8nd/H3fR6kDVWy9ttokFpTHT1yX7vT2 0iE/l4A+KXcBmeG3dUiCZo79hm8HSWq8aO4dqByrkrTfyc7t4dGZpGKmYkyP9oQn3OkO7g5GZ15+H VkBxOCC1kZsxL+oa50ReQZdb2C2j0YTOjdcdPAzmi3AuhSFi+YVT4oiW92ad6yNlIT13ZDMaAa8dF ZggY/wdXgHKhQVGNWBEEVQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNTAl-0007gZ-Bi; Thu, 02 Feb 2023 01:34:15 -0500 In-Reply-To: <957c7e3e-830e-0a03-562f-fdddc6bd1c06@yandex.ru> (message from Dmitry Gutov on Wed, 1 Feb 2023 23:20:50 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254625 Archived-At: > Date: Wed, 1 Feb 2023 23:20:50 +0200 > Cc: casouri@gmail.com, 60953@debbugs.gnu.org > From: Dmitry Gutov > > On 01/02/2023 15:39, Eli Zaretskii wrote: > >> Please see the attachment. > >> > >> To note the numbers: the first patch does quite well to improve the > >> performance of modes which use :match in queries which match a lot of > >> nodes (e.g. rust-ts-mode or ruby-ts-mode). There boost in those was on > >> the order of 25%. > >> > >> The second one is longer, and the boost (on top of the first one) is > >> around 5-6%, stable. Not as impressive, but at least it brings :match's > >> performance a little above :pred's in my example. > > Fine by me, if Yuan also approves. > > For emacs-29, right? Yes.