* bug#62763: 29.0.90; failed test during build
@ 2023-04-10 16:26 Tim Heaney
2023-04-11 6:14 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Tim Heaney @ 2023-04-10 16:26 UTC (permalink / raw)
To: 62763
[-- Attachment #1: Type: text/plain, Size: 3790 bytes --]
When I build it like this
./autogen.sh
./configure --with-native-compilation
make -j16
make -j16 check
that check gives me one bad result
SUMMARY OF TEST RESULTS
-----------------------
Files examined: 467
Ran 7157 tests, 6996 results as expected, 1 unexpected, 160 skipped
1 files contained unexpected results:
lisp/image/wallpaper-tests.log
make[2]: *** [Makefile:341: check-doit] Error 1
make[2]: Leaving directory '/home/tim/Emacs/emacs-29.0.90/test'
make[1]: *** [Makefile:310: check] Error 2
make[1]: Leaving directory '/home/tim/Emacs/emacs-29.0.90/test'
make: *** [Makefile:1097: check] Error 2
In GNU Emacs 29.0.90 (build 2, x86_64-pc-linux-gnu, GTK+ Version
3.24.36, cairo version 1.16.0) of 2023-04-10 built on calvin
Windowing system distributor 'The X.Org Foundation', version 11.0.12101007
System Description: Debian GNU/Linux bookworm/sid
Configured using:
'configure --with-native-compilation'
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3
THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB
Important settings:
value of $LC_MONETARY: en_US.UTF-8
value of $LC_NUMERIC: en_US.UTF-8
value of $LC_TIME: en_US.UTF-8
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: @im=ibus
locale-coding-system: utf-8-unix
Major mode: Fundamental
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
buffer-read-only: t
line-number-mode: t
indent-tabs-mode: t
transient-mark-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date comp
comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra help-mode
cl-loaddefs cl-lib bytecomp byte-compile rmc iso-transl tooltip cconv
eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process
native-compile emacs)
Memory information:
((conses 16 99949 9205)
(symbols 48 7142 0)
(strings 32 28569 2307)
(string-bytes 1 911408)
(vectors 16 22196)
(vector-slots 8 383004 17914)
(floats 8 44 25)
(intervals 56 313 6)
(buffers 976 12))
[-- Attachment #2: Type: text/html, Size: 4212 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#62763: 29.0.90; failed test during build
2023-04-10 16:26 bug#62763: 29.0.90; failed test during build Tim Heaney
@ 2023-04-11 6:14 ` Eli Zaretskii
2023-04-11 11:11 ` Tim Heaney
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2023-04-11 6:14 UTC (permalink / raw)
To: Tim Heaney; +Cc: 62763
> From: Tim Heaney <theaney@gmail.com>
> Date: Mon, 10 Apr 2023 12:26:08 -0400
>
> When I build it like this
>
> ./autogen.sh
> ./configure --with-native-compilation
> make -j16
> make -j16 check
>
> that check gives me one bad result
>
> SUMMARY OF TEST RESULTS
> -----------------------
> Files examined: 467
> Ran 7157 tests, 6996 results as expected, 1 unexpected, 160 skipped
> 1 files contained unexpected results:
> lisp/image/wallpaper-tests.log
> make[2]: *** [Makefile:341: check-doit] Error 1
> make[2]: Leaving directory '/home/tim/Emacs/emacs-29.0.90/test'
> make[1]: *** [Makefile:310: check] Error 2
> make[1]: Leaving directory '/home/tim/Emacs/emacs-29.0.90/test'
> make: *** [Makefile:1097: check] Error 2
Thanks, but please post the contents of
lisp/image/wallpaper-tests.log you get, so we could see what exactly
fails in your case. wallpaper.el uses different methods for different
system configurations, so just saying its test suite fails is not
enough to understand what could be the reason.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#62763: 29.0.90; failed test during build
2023-04-11 6:14 ` Eli Zaretskii
@ 2023-04-11 11:11 ` Tim Heaney
2023-04-11 13:03 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Tim Heaney @ 2023-04-11 11:11 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 62763
[-- Attachment #1.1: Type: text/plain, Size: 91 bytes --]
Here it is. I found it under test/lisp, not just lisp
test/lisp/image/wallpaper-tests.log
[-- Attachment #1.2: Type: text/html, Size: 136 bytes --]
[-- Attachment #2: wallpaper-tests.log --]
[-- Type: text/x-log, Size: 2843 bytes --]
Running 20 tests (2023-04-10 12:04:22-0400, selector `(not (or (tag :expensive-test) (tag :unstable)))')
Test wallpaper--find-command-args/return-list backtrace:
signal(ert-test-failed (((should (or (not (wallpaper--find-command-a
ert-fail(((should (or (not (wallpaper--find-command-args)) (listp (w
#f(compiled-function () #<bytecode -0xf1c8e61287de8c8>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name wallpaper--find-command-args/return-l
ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...
ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/image/wallpaper-test
command-line()
normal-top-level()
Test wallpaper--find-command-args/return-list condition:
(ert-test-failed
((should
(or
(not ...)
(listp ...)))
:form
(or
(not
(wallpaper--find-command-args))
(listp
(wallpaper--find-command-args)))
:value nil))
FAILED 1/20 wallpaper--find-command-args/return-list (0.000127 sec) at lisp/image/wallpaper-tests.el:128
passed 2/20 wallpaper--find-command/return-string (0.000064 sec)
passed 3/20 wallpaper--find-setter (0.000203 sec)
passed 4/20 wallpaper--find-setter/call-predicate (0.000192 sec)
passed 5/20 wallpaper--find-setter/set-current-setter (0.000182 sec)
passed 6/20 wallpaper--format-arg/filename (0.000410 sec)
passed 7/20 wallpaper--format-arg/filename-hex (0.011550 sec)
passed 8/20 wallpaper--format-arg/height (0.000092 sec)
passed 9/20 wallpaper--format-arg/monitor (0.000076 sec)
passed 10/20 wallpaper--format-arg/screen (0.000065 sec)
passed 11/20 wallpaper--format-arg/width (0.000063 sec)
passed 12/20 wallpaper--format-arg/workspace (0.000072 sec)
passed 13/20 wallpaper--get-default-file/empty-gives-nil (0.006245 sec)
passed 14/20 wallpaper--get-default-file/file-at-point (0.004047 sec)
passed 15/20 wallpaper--get-default-file/visiting-file (0.000751 sec)
passed 16/20 wallpaper--image-file-regexp/return-string (0.000099 sec)
Desktop wallpaper changed to /tmp/emacs-test-ZMjmPd.jpg
passed 17/20 wallpaper-set/calls-init-action (0.001781 sec)
passed 18/20 wallpaper-set/calls-wallpaper-set-function (0.000297 sec)
Desktop wallpaper changed to /tmp/emacs-test-sf7h0n.jpg
passed 19/20 wallpaper-set/runs-command (0.002194 sec)
passed 20/20 wallpaper-set/runs-command/detach (0.002114 sec)
Ran 20 tests, 19 results as expected, 1 unexpected (2023-04-10 12:04:22-0400, 0.086526 sec)
1 unexpected results:
FAILED wallpaper--find-command-args/return-list
^ permalink raw reply [flat|nested] 8+ messages in thread* bug#62763: 29.0.90; failed test during build
2023-04-11 11:11 ` Tim Heaney
@ 2023-04-11 13:03 ` Eli Zaretskii
2023-04-11 13:23 ` Tim Heaney
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2023-04-11 13:03 UTC (permalink / raw)
To: Tim Heaney; +Cc: 62763
> From: Tim Heaney <theaney@gmail.com>
> Date: Tue, 11 Apr 2023 07:11:18 -0400
> Cc: 62763@debbugs.gnu.org
>
> Here it is. I found it under test/lisp, not just lisp
>
> test/lisp/image/wallpaper-tests.log
Thanks. Strange.
Can you please perform the steps below and report the results?
emacs -Q
M-x load-library RET wallpaper RET
M-: (wallpaper--find-setter) RET
The last two commands should display the wallpaper setter structure to
be used in your environment -- please post that in its entirety.
Also, what happens if you run just this one test file, like this:
$ cd test
$ make lisp/image/wallpaper-tests
Does it succeed then , or does it still fail?
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#62763: 29.0.90; failed test during build
2023-04-11 13:03 ` Eli Zaretskii
@ 2023-04-11 13:23 ` Tim Heaney
2023-04-11 13:42 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Tim Heaney @ 2023-04-11 13:23 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 62763
[-- Attachment #1: Type: text/plain, Size: 3872 bytes --]
Here is the *Messages* buffer after the first part
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading wallpaper...done
You can run the command ‘load-library’ with M-x loa-l
Loading wallpaper...done
#s(wallpaper-setter "XFCE" "xfconf-query" wallpaper-xfce-command-args #[0
"! \0! \0 " [getenv "DESKTOP_SESSION" ("xubuntu" "ubuntustudio") "XFCE"
xdg-current-desktop] 2] nil nil)
The second part still fails
Emacs/emacs-29.0.90/test
✦ ❯ make lisp/image/wallpaper-tests
make[1]: Entering directory '/home/tim/Emacs/emacs-29.0.90/test'
GEN lisp/image/wallpaper-tests.log
Running 20 tests (2023-04-11 09:20:51-0400, selector `(not (tag
:unstable))')
Test wallpaper--find-command-args/return-list backtrace:
signal(ert-test-failed (((should (or (not (wallpaper--find-command-a
ert-fail(((should (or (not (wallpaper--find-command-args)) (listp (w
(if (unwind-protect (setq value-70 (or (not (wallpaper--find-command
(let (form-description-71) (if (unwind-protect (setq value-70 (or (n
(let ((value-70 (gensym "ert-form-evaluation-aborted-"))) (let (form
(closure (t) nil (let ((value-70 (gensym "ert-form-evaluation-aborte
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name wallpaper--find-command-args/return-l
ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/image/wallpaper-test
command-line()
normal-top-level()
Test wallpaper--find-command-args/return-list condition:
(ert-test-failed
((should
(or
(not ...)
(listp ...)))
:form
(or
(not
(wallpaper--find-command-args))
(listp
(wallpaper--find-command-args)))
:value nil))
FAILED 1/20 wallpaper--find-command-args/return-list (0.000107 sec)
at lisp/image/wallpaper-tests.el:128
passed 2/20 wallpaper--find-command/return-string (0.000047 sec)
passed 3/20 wallpaper--find-setter (0.000185 sec)
passed 4/20 wallpaper--find-setter/call-predicate (0.000195 sec)
passed 5/20 wallpaper--find-setter/set-current-setter (0.000165 sec)
passed 6/20 wallpaper--format-arg/filename (0.000345 sec)
passed 7/20 wallpaper--format-arg/filename-hex (0.009361 sec)
passed 8/20 wallpaper--format-arg/height (0.000067 sec)
passed 9/20 wallpaper--format-arg/monitor (0.000066 sec)
passed 10/20 wallpaper--format-arg/screen (0.000065 sec)
passed 11/20 wallpaper--format-arg/width (0.000068 sec)
passed 12/20 wallpaper--format-arg/workspace (0.000057 sec)
passed 13/20 wallpaper--get-default-file/empty-gives-nil (0.006376 sec)
passed 14/20 wallpaper--get-default-file/file-at-point (0.014131 sec)
passed 15/20 wallpaper--get-default-file/visiting-file (0.000416 sec)
passed 16/20 wallpaper--image-file-regexp/return-string (0.000050 sec)
Desktop wallpaper changed to /tmp/emacs-test-CxuJrO.jpg
passed 17/20 wallpaper-set/calls-init-action (0.001059 sec)
passed 18/20 wallpaper-set/calls-wallpaper-set-function (0.000172 sec)
Desktop wallpaper changed to /tmp/emacs-test-l6ctHj.jpg
passed 19/20 wallpaper-set/runs-command (0.001644 sec)
passed 20/20 wallpaper-set/runs-command/detach (0.001639 sec)
Ran 20 tests, 19 results as expected, 1 unexpected (2023-04-11
09:20:51-0400, 0.084415 sec)
1 unexpected results:
FAILED wallpaper--find-command-args/return-list
make[1]: *** [Makefile:181: lisp/image/wallpaper-tests.log] Error 1
make[1]: Leaving directory '/home/tim/Emacs/emacs-29.0.90/test'
make: *** [Makefile:247: lisp/image/wallpaper-tests] Error 2
[-- Attachment #2: Type: text/html, Size: 4439 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* bug#62763: 29.0.90; failed test during build
2023-04-11 13:23 ` Tim Heaney
@ 2023-04-11 13:42 ` Eli Zaretskii
2023-04-11 13:57 ` Tim Heaney
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2023-04-11 13:42 UTC (permalink / raw)
To: Tim Heaney; +Cc: 62763
> From: Tim Heaney <theaney@gmail.com>
> Date: Tue, 11 Apr 2023 09:23:11 -0400
> Cc: 62763@debbugs.gnu.org
>
> Here is the *Messages* buffer after the first part
>
> For information about GNU Emacs and the GNU system, type C-h C-a.
> Loading wallpaper...done
> You can run the command ‘load-library’ with M-x loa-l
> Loading wallpaper...done
> #s(wallpaper-setter "XFCE" "xfconf-query" wallpaper-xfce-command-args #[0 "! \0! \0 " [getenv
> "DESKTOP_SESSION" ("xubuntu" "ubuntustudio") "XFCE" xdg-current-desktop] 2] nil nil)
Thanks. Does the patch below fix the error?
diff --git a/test/lisp/image/wallpaper-tests.el b/test/lisp/image/wallpaper-tests.el
index 2e4e360..c4167ad 100644
--- a/test/lisp/image/wallpaper-tests.el
+++ b/test/lisp/image/wallpaper-tests.el
@@ -129,12 +129,16 @@ wallpaper-set/calls-wallpaper-set-function
(should (equal called fil-jpg)))))
(ert-deftest wallpaper--find-command/return-string ()
- (should (or (not (wallpaper--find-command))
- (stringp (wallpaper--find-command)))))
+ (let ((cmd (wallpaper--find-command)))
+ (should (or (not cmd)
+ (stringp cmd)))))
(ert-deftest wallpaper--find-command-args/return-list ()
- (should (or (not (wallpaper--find-command-args))
- (listp (wallpaper--find-command-args)))))
+ (let ((cmdargs (wallpaper--find-command-args)))
+ (if (functionp cmdargs)
+ (setq cmdargs (funcall cmdargs)))
+ (should (or (not cmdargs)
+ (listp cmdargs)))))
(ert-deftest wallpaper--image-file-regexp/return-string ()
(should (stringp (wallpaper--image-file-regexp))))
^ permalink raw reply related [flat|nested] 8+ messages in thread* bug#62763: 29.0.90; failed test during build
2023-04-11 13:42 ` Eli Zaretskii
@ 2023-04-11 13:57 ` Tim Heaney
2023-04-11 14:49 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Tim Heaney @ 2023-04-11 13:57 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 62763
[-- Attachment #1: Type: text/plain, Size: 1951 bytes --]
Yes, that does it!
❯ make lisp/image/wallpaper-tests
make[1]: Entering directory '/home/tim/Emacs/emacs-29.0.90/test'
ELC+ELN lisp/image/wallpaper-tests.elc
GEN lisp/image/wallpaper-tests.log
Running 20 tests (2023-04-11 09:55:36-0400, selector `(not (tag
:unstable))')
passed 1/20 wallpaper--find-command-args/return-list (0.021983 sec)
passed 2/20 wallpaper--find-command/return-string (0.000102 sec)
passed 3/20 wallpaper--find-setter (0.000444 sec)
passed 4/20 wallpaper--find-setter/call-predicate (0.000424 sec)
passed 5/20 wallpaper--find-setter/set-current-setter (0.000388 sec)
passed 6/20 wallpaper--format-arg/filename (0.000593 sec)
passed 7/20 wallpaper--format-arg/filename-hex (0.010103 sec)
passed 8/20 wallpaper--format-arg/height (0.000071 sec)
passed 9/20 wallpaper--format-arg/monitor (0.000067 sec)
passed 10/20 wallpaper--format-arg/screen (0.000062 sec)
passed 11/20 wallpaper--format-arg/width (0.000059 sec)
passed 12/20 wallpaper--format-arg/workspace (0.000054 sec)
passed 13/20 wallpaper--get-default-file/empty-gives-nil (0.006273 sec)
passed 14/20 wallpaper--get-default-file/file-at-point (0.002885 sec)
passed 15/20 wallpaper--get-default-file/visiting-file (0.000414 sec)
passed 16/20 wallpaper--image-file-regexp/return-string (0.000057 sec)
Desktop wallpaper changed to /tmp/emacs-test-3JWhD9.jpg
passed 17/20 wallpaper-set/calls-init-action (0.001792 sec)
passed 18/20 wallpaper-set/calls-wallpaper-set-function (0.000192 sec)
Desktop wallpaper changed to /tmp/emacs-test-s7gOm7.jpg
passed 19/20 wallpaper-set/runs-command (0.001794 sec)
passed 20/20 wallpaper-set/runs-command/detach (0.001800 sec)
Ran 20 tests, 20 results as expected, 0 unexpected (2023-04-11
09:55:36-0400, 0.050690 sec)
make[1]: Leaving directory '/home/tim/Emacs/emacs-29.0.90/test'
[-- Attachment #2: Type: text/html, Size: 2198 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-04-11 14:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-10 16:26 bug#62763: 29.0.90; failed test during build Tim Heaney
2023-04-11 6:14 ` Eli Zaretskii
2023-04-11 11:11 ` Tim Heaney
2023-04-11 13:03 ` Eli Zaretskii
2023-04-11 13:23 ` Tim Heaney
2023-04-11 13:42 ` Eli Zaretskii
2023-04-11 13:57 ` Tim Heaney
2023-04-11 14:49 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.