all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Sedach <vas@oneofus.la>
Cc: 64311@debbugs.gnu.org
Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers
Date: Fri, 30 Jun 2023 08:40:12 +0300	[thread overview]
Message-ID: <835y75tsn7.fsf@gnu.org> (raw)
In-Reply-To: <87ttuqax6d.fsf@t510.orion.oneofus.la> (message from Vladimir Sedach on Thu, 29 Jun 2023 13:24:58 -0600)

> From: Vladimir Sedach <vas@oneofus.la>
> Cc: 64311@debbugs.gnu.org
> Date: Thu, 29 Jun 2023 13:24:58 -0600
> 
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Am I?  Asking about the root cause of the problem is not wrong,
> > because it indicates how best to fix it.
> 
> The root cause of the problem is the redundant variable
> shell-dirtrackp, not its value. It is the variable aliasing in the
> 2018 commit 9c3eeba4db26ddaeead100beea7a96f9fa640918 that introduced
> the bug.
> 
> This is why my patch addresses the root cause of the problem, instead
> of setting the value of the variable (which commit
> 9c3eeba4db26ddaeead100beea7a96f9fa640918 did not touch).

The variable's existence is only the cause of the problem because of
its value.

> > Why would we bother about that?  With the exception of the default
> > value, what harm does that variable cause by existing?
> 
> It is misleading for someone trying to customize shell-mode, or work
> on shell.el. I found it confusing on both counts.

Such confusion can be prevented by adding appropriate comments.

By contrast, removing the variable, or declaring it obsolete, is
backward-incompatible change in behavior, which we try to avoid at all
costs.  In this case, I see absolutely no justification for such
backward incompatibility.  We wouldn't be able to defend such a change
if it caused someone annoyance or, worse, breakage of their Emacs
setup and usage.

> If it were not confusing for you too, we obviously would not be
> having such a long back-and-forth conversation about this bug.

The discussion was long because I couldn't connect between the problem
and the changes you proposed.  The solution I thought about
immediately was just to change the value of the variable.  The rest
was getting you to agree that such a change would indeed solve the
problem (although you disagree it's the right solution).





  reply	other threads:[~2023-06-30  5:40 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27  4:39 bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Vladimir Sedach
2023-06-27 11:18 ` Eli Zaretskii
2023-06-27 14:09   ` Vladimir Sedach
2023-06-27 15:52     ` Eli Zaretskii
2023-06-28  0:07       ` Vladimir Sedach
2023-06-28 11:46         ` Eli Zaretskii
2023-06-28 16:43           ` Vladimir Sedach
2023-06-28 18:31             ` Eli Zaretskii
2023-06-28 20:14               ` Vladimir Sedach
2023-06-29  4:57                 ` Eli Zaretskii
2023-06-29 16:26                   ` Vladimir Sedach
2023-06-29 18:10                     ` Eli Zaretskii
2023-06-29 19:24                       ` Vladimir Sedach
2023-06-30  5:40                         ` Eli Zaretskii [this message]
2023-06-30 16:47                           ` Vladimir Sedach
2023-07-02  6:39                             ` Eli Zaretskii
2023-07-03 17:03                               ` Vladimir Sedach
2023-07-03 17:17                                 ` Eli Zaretskii
2023-07-04 14:28                               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 16:05                                 ` Eli Zaretskii
2023-07-04 18:34                                   ` Vladimir Sedach
2023-07-04 20:36                                   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 22:27                                     ` Vladimir Sedach
2023-07-04 23:42                                       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-06 20:30                                         ` Vladimir Sedach
2023-07-08  8:30                                           ` Eli Zaretskii
2023-07-08 16:18                                             ` Vladimir Sedach
2023-07-08 16:31                                               ` Eli Zaretskii
2023-07-04  3:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 11:21   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835y75tsn7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=64311@debbugs.gnu.org \
    --cc=vas@oneofus.la \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.