From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Fri, 14 Jul 2023 18:56:06 +0300 Message-ID: <835y6mfpwp.fsf@gnu.org> References: <877cr4nez9.fsf@localhost> <83v8eo3pfv.fsf@gnu.org> <87bkgeiuap.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23143"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yantar92@posteo.net, 64596@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 14 17:56:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKL9Y-0005jM-Ei for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jul 2023 17:56:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKL9I-0001ib-Pi; Fri, 14 Jul 2023 11:56:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKL9H-0001iI-15 for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2023 11:56:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKL9G-0006JW-7d for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2023 11:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKL9G-0005Sl-38 for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2023 11:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jul 2023 15:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64596 X-GNU-PR-Package: emacs Original-Received: via spool by 64596-submit@debbugs.gnu.org id=B64596.168935015820990 (code B ref 64596); Fri, 14 Jul 2023 15:56:02 +0000 Original-Received: (at 64596) by debbugs.gnu.org; 14 Jul 2023 15:55:58 +0000 Original-Received: from localhost ([127.0.0.1]:43291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKL9B-0005SU-Vq for submit@debbugs.gnu.org; Fri, 14 Jul 2023 11:55:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKL9A-0005SH-9H for 64596@debbugs.gnu.org; Fri, 14 Jul 2023 11:55:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKL93-0005VN-Dy; Fri, 14 Jul 2023 11:55:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BxcNCjnitzFicCyBWen11egZoW81M3KlUeLrIswUIyo=; b=I0w84sU7pBe8 WCdZlFnaULIiwYJz2KuqTPBJtpEtPEh3dMHoX9IrtZU8cLddhpLBs5S03gr/iJObng+tP+XcQOd3Z s5kc1LZmDMVu8XAK5pwXfTwwdUnloomYhzrn0cnqBt+fdKe4AmlS68RpxsF7EpsMOwQBDOM3IdTh2 1ZMKFJtLsBJG018sxh4MwPFd/LzK322UtGiGebJajygDT+ee0AyR7zdxmQ3zBvoGbvZtEf+CFg9zi q/zZXqqk1Xn+jk0c7sEu1FIccBQKZM6WVMegC/1f11gqQLsA7tGWwWla3734nn7kGoA17U9jypWP9 MAXsDOGEShjwv7kUeQu+gg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKL91-0007qx-G9; Fri, 14 Jul 2023 11:55:49 -0400 In-Reply-To: (message from Stefan Monnier on Fri, 14 Jul 2023 10:20:32 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265105 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , 64596@debbugs.gnu.org > Date: Fri, 14 Jul 2023 10:20:32 -0400 > > `prevent_redisplay_optimizations_p` is just another of those vars. > The problem with that var is not its existence but the fact that by now > noone knows what it means, so we can't touch that code, basically :-( I think we can touch that code, but we need to do it carefully, and we need to leave behind a "fire escape". If you look at its uses (not where the flag is set, but where it is checked), you will see that it either disables some optimization (example: in try_window_id), or sets other variables, like current_matrix_up_to_date_p. In the first case, we need to go over the places where the flag is set to true and think whether those setters indeed need to disable each particular optimization. In the second case, I think the flag is basically used to quickly disable optimizations conditioned by those other variables, in a way that prevents us to make more expensive tests. If we understand better each of these cases -- and there aren't so many of them -- we then could discuss whether to set the flag or not and whether to replace it with something else, whether those are other, more descriptive, flags or nothing.