From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: glebsmirnov0708@gmail.com, ivan-p-sokolov@ya.ru, 65760@debbugs.gnu.org
Subject: bug#65760: 29.1; eglot performance issue
Date: Tue, 05 Sep 2023 19:25:28 +0300 [thread overview]
Message-ID: <835y4o4mfb.fsf@gnu.org> (raw)
In-Reply-To: <837cp44mko.fsf@gnu.org> (message from Eli Zaretskii on Tue, 05 Sep 2023 19:22:15 +0300)
Adding João.
> Cc: 65760@debbugs.gnu.org, glebsmirnov0708@gmail.com
> Date: Tue, 05 Sep 2023 19:22:15 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > Cc: 65760@debbugs.gnu.org
> > From: Ivan Sokolov <ivan-p-sokolov@ya.ru>
> > Date: Tue, 05 Sep 2023 18:55:23 +0300
> >
> > Глеб Смирнов <glebsmirnov0708@gmail.com> writes:
> >
> > > The problem is that running eglot with rust-analyzer on my project
> > > causes major input lag. Profiling shows that the problem is in
> > > synchronous and slow function jsonrpc--log-event that is called on each
> > > server request or response. Disabling this function with (advice-add
> > > 'jsonrpc--log-event :override #'ignore) solves the problem.
> >
> > To be more precise the problem is that jsonrpc--log-event is pretty
> > printing every reply from the server and they can be quite large and
> > nested. I am attaching Gleb's profiler report, as a screenshot, but
> > this should be enough to give a better understanding of the problem.
>
> Yes, the real CPU eater is pp-buffer.
>
> But I also see that jsonrpc-request took a substantial amount of CPU
> time, and since jsonrpc-request runs from a timer, it is a good
> candidate for explaining a perceived lag.
>
> Can you tell if this profile was in an Emacs build with built-in JSON
> support, or was Emacs using the Lisp implementation on json.el?
>
>
>
>
next prev parent reply other threads:[~2023-09-05 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 9:01 bug#65760: 29.1; eglot performance issue Глеб Смирнов
2023-09-05 15:55 ` Ivan Sokolov
2023-09-05 16:22 ` Eli Zaretskii
2023-09-05 16:25 ` Eli Zaretskii [this message]
2023-09-05 16:45 ` João Távora
2023-09-05 16:59 ` Axel Forsman
2023-09-05 17:11 ` João Távora
2023-09-05 17:20 ` Ivan Sokolov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835y4o4mfb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65760@debbugs.gnu.org \
--cc=glebsmirnov0708@gmail.com \
--cc=ivan-p-sokolov@ya.ru \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.