From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67568: Emacs master: Bug in byte compiler when there's an unused parameter. Date: Sun, 03 Dec 2023 21:28:01 +0200 Message-ID: <835y1f6q7y.fsf@gnu.org> References: <1c2d9219-093c-0726-13ce-2c952f6e33ba@gutov.dev> <83il5f6yuz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19782"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, acm@muc.de, 67568-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 03 20:29:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r9s9G-0004ty-Ez for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Dec 2023 20:29:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r9s98-0002bz-2m; Sun, 03 Dec 2023 14:28:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9s96-0002bj-RR for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 14:28:53 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r9s96-0005Db-JA for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 14:28:52 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r9s9G-0004ve-Kq for bug-gnu-emacs@gnu.org; Sun, 03 Dec 2023 14:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Dec 2023 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67568 X-GNU-PR-Package: emacs Original-Received: via spool by 67568-done@debbugs.gnu.org id=D67568.170163170018894 (code D ref 67568); Sun, 03 Dec 2023 19:29:02 +0000 Original-Received: (at 67568-done) by debbugs.gnu.org; 3 Dec 2023 19:28:20 +0000 Original-Received: from localhost ([127.0.0.1]:32799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9s8a-0004uf-A0 for submit@debbugs.gnu.org; Sun, 03 Dec 2023 14:28:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r9s8Y-0004uS-1E for 67568-done@debbugs.gnu.org; Sun, 03 Dec 2023 14:28:19 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r9s8I-0005A8-Eg; Sun, 03 Dec 2023 14:28:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=47Hizgf/e+IO3Z16yYfJsgW3sXWfn+JFGVenK8gGJ/o=; b=Swm1svnqlqfHq29wpXXP dWQYiMv8TvWTCo4c1uKgihWxSROT+h4Enji8nm8zBVb/to4UQwXRpHVE9LHKCdj0VpaRBxv8WX18v rnnN3mCsMeu+ZGHhIi9c6Ra9r1ikRT8V4nH6HVN2hX1cN1s7QoqoG9kECRc9SrXimI8GlSrC3ExY0 1ZrjBH/HMmLfn0lnnksg0Kmx67ELY2SLoCT0lJLawB98yX156XEiZTaRTASitqWgfrjDA2FjH6rhK 978x3qZYtPFII8v291An0t0BkWulGL6D1dmfRl80d6N6QuxRfsHialWzYUklIgrh3Pj1hTu8zy9h5 fAi77wX2M4w8jw==; In-Reply-To: (message from Stefan Monnier on Sun, 03 Dec 2023 14:24:44 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275450 Archived-At: > From: Stefan Monnier > Cc: acm@muc.de, 67568-done@debbugs.gnu.org, dmitry@gutov.dev > Date: Sun, 03 Dec 2023 14:24:44 -0500 > > >> I'm wondering whether it should go to `emacs-29` or to `master`. > >> I'm leaning toward `emacs-29` because it's rather embarrassing (and > >> perplexing for the user) and the patch is simple. > >> Eli? Stefan? > > No objections from me. > > It turns out the bug is not present in `emacs-29`, it was introduced on > master by: > > commit f616edb4ccce5b9d60e3ff42806bd2131989cd1e > Author: Mattias Engdegård > Date: Mon Sep 25 14:40:11 2023 +0200 > > macroexp-parse-body: correct parsing of empty body (bug#66136) > > * lisp/emacs-lisp/macroexp.el (macroexp-parse-body): > Return an empty body even when there are declarations present. > Previously, the last declaration was considered part of the body, > which is only correct if the input consists of a single string. > > Reported by Jens Schmidt. > > So I pushed a better fix, on master. Great, thanks.