From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.bugs
Subject: bug#66394: 29.1; Make register-read-with-preview more useful
Date: Sat, 23 Dec 2023 12:49:16 +0200
Message-ID: <835y0pdwib.fsf@gnu.org>
References: <87il7ib6cu.fsf@posteo.net> <871qbsk5le.fsf@posteo.net>
 <f7f749d1-3a2d-0ea0-a106-6c586f4faca7@gutov.dev>
 <87v894hr2e.fsf@posteo.net> <87cyvbepi0.fsf@posteo.net>
 <87bkavk9nv.fsf@posteo.net>
 <8eebbb30-9366-e869-a39a-8100638cb99a@gutov.dev>
 <87o7etgxeb.fsf@posteo.net> <83v891qlcn.fsf@gnu.org>
 <jwvfs04hjm9.fsf-monnier+emacs@gnu.org>
 <CADwFkmm3H9+-nrYi0JQM9YT0_ZYU3SYvcqfmEnEpJWWaZzHTGQ@mail.gmail.com>
 <87r0jn4j8i.fsf@posteo.net> <jwv8r5vfqo6.fsf-monnier+emacs@gnu.org>
 <87jzpf48k5.fsf@posteo.net> <jwvplz73vpg.fsf-monnier+emacs@gnu.org>
 <87plz6xp3m.fsf@posteo.net> <jwvzfya2mk9.fsf-monnier+emacs@gnu.org>
 <8734vym6ok.fsf@posteo.net> <83ttodgjtk.fsf@gnu.org>
 <87cyv0hjp9.fsf@posteo.net> <83wmt7g4k8.fsf@gnu.org>
 <87edff3019.fsf@posteo.net>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="29526"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: michael_heerdegen@web.de, dmitry@gutov.dev, 66394-done@debbugs.gnu.org,
 monnier@iro.umontreal.ca, stefankangas@gmail.com
To: Thierry Volpiatto <thievol@posteo.net>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 23 11:50:16 2023
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1rGzaA-0007NN-Ep
	for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Dec 2023 11:50:14 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1rGzZv-0003Ba-LP; Sat, 23 Dec 2023 05:49:59 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1rGzZt-0003Ax-MV
 for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 05:49:57 -0500
Original-Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1rGzZt-0005l8-EI
 for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 05:49:57 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rGzZy-0001AQ-4A
 for bug-gnu-emacs@gnu.org; Sat, 23 Dec 2023 05:50:02 -0500
Resent-From: Eli Zaretskii <eliz@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-gnu-emacs@gnu.org
Resent-Date: Sat, 23 Dec 2023 10:50:01 +0000
Resent-Message-ID: <handler.66394.D66394.17033285924463.done@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: cc-closed 66394
X-GNU-PR-Package: emacs
Mail-Followup-To: 66394@debbugs.gnu.org, eliz@gnu.org, thievol@posteo.net
Original-Received: via spool by 66394-done@debbugs.gnu.org id=D66394.17033285924463
 (code D ref 66394); Sat, 23 Dec 2023 10:50:01 +0000
Original-Received: (at 66394-done) by debbugs.gnu.org; 23 Dec 2023 10:49:52 +0000
Original-Received: from localhost ([127.0.0.1]:48684 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1rGzZo-00019v-0m
 for submit@debbugs.gnu.org; Sat, 23 Dec 2023 05:49:52 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40542)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@gnu.org>) id 1rGzZi-00019f-Vn
 for 66394-done@debbugs.gnu.org; Sat, 23 Dec 2023 05:49:50 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1rGzZX-0005i6-Pm; Sat, 23 Dec 2023 05:49:35 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=pjI08+SKsbQpIcFgJlGUtPudE8FX0J320AXpIaxaJPc=; b=HPmqpl2/gduC
 y7aHoNERPXShkTAofd0uG95YHOO4y3pYcaO3qA3VRaQ2Cz/n8+fuZlcJROI3u/4VxyNS3omxTEBo5
 5CdE6ATOqlLrotuLmFmivzMqq+6SYYMlk1QqM5bA//QJbzECBXpf9mac8Jd1hrrGpLf/iJaoFvvRf
 g7jaNHMhdbAA28P4slz6zgSSr0YIPvs+9DTUwPDKN+rcl7rL5RijkUs+x9xpR1xHkUu5IFZD8kg+k
 ZCCgjKCUX/TuWymUh2K2d71esZieYKhYdBu5BPx7LQZPiOVYO/S7k3cPVKybnm8RITNHYV+1mysQL
 CzFHXgl4YR317X+5pK4X6w==;
In-Reply-To: <87edff3019.fsf@posteo.net> (message from Thierry Volpiatto on
 Thu, 21 Dec 2023 18:04:02 +0000)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:276731
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/276731>

> From: Thierry Volpiatto <thievol@posteo.net>
> Cc: monnier@iro.umontreal.ca,  stefankangas@gmail.com,  dmitry@gutov.dev,
>   michael_heerdegen@web.de,  66394@debbugs.gnu.org
> Date: Thu, 21 Dec 2023 18:04:02 +0000
> 
> > Thanks, I have a question:
> >
> > The doc string of register-use-preview says:
> >
> >   This has no effect when the value of `register--read-with-preview-function'
> >   is `register-read-with-preview-traditional'.
> >
> > However, customizing register-use-preview to the value 'traditional
> > has the exact effect of setting register--read-with-preview-function
> > to register-read-with-preview-traditional.  OTOH, when
> > register-use-preview is set to 'traditional, one can set it to a
> > different value, and then the behavior will change.  So I wonder what
> > that sentence is about and what I missed?  Is that perhaps a leftover
> > from previous versions, and should now be deleted?
> 
> Yes exactly, it can be deleted.
> 
> > I updated the documentation and NEWS.  I'd appreciate if you could
> > spare a few minutes to review the changes and point out any
> > inaccuracies or mistakes.
> 
> About the documentation or register-use-preview in the manual:
> 
> Another difference with the old behavior (traditional) is that the
> preview is filtered according to type of registers used by command.  For
> example insert-register show only the registers that can be inserted,
> not windows, markers etc... Same for jump.
> 
>     -  "Returns a function to format a register for previewing.
>     -This according to the value of READ-PREVIEW-FUNCTION.")
>     +  "Return a function to format a register for previewing.
>     +This is according to the value of `read-preview-function'.")
> 
> Here READ-PREVIEW-FUNCTION is the argument of function and not a
> variable, so IMO it should be upcased and not quoted.
> 
>      (cl-defstruct register-preview-info
>        "Store data for a specific register command.
>     -TYPES are the types of register supported.
>     -MSG is the minibuffer message to send when a register is selected.
>     +TYPES are the supported types of registers.
>     +MSG is the minibuffer message to show when a register is selected.
>      ACT is the type of action the command is doing on register.
>     -SMATCH accept a boolean value to say if command accept non matching register."
>     +SMATCH accept a boolean value to say if the command accepts non-matching
>     +registers."
>        types msg act smatch noconfirm)
> 
> NOCONFIRM is not documented (my fault).
> When set to nil don't request confirmation with RET.
> 
> Otherwise all looks good to me, thanks.

Thanks, I fixed all of the above, and I'm therefore closing this bug.