From: Eli Zaretskii <eliz@gnu.org>
To: Thierry Volpiatto <thievol@posteo.net>
Cc: michael_heerdegen@web.de, dmitry@gutov.dev,
66394-done@debbugs.gnu.org, monnier@iro.umontreal.ca,
stefankangas@gmail.com
Subject: bug#66394: 29.1; Make register-read-with-preview more useful
Date: Sat, 23 Dec 2023 12:49:16 +0200 [thread overview]
Message-ID: <835y0pdwib.fsf@gnu.org> (raw)
In-Reply-To: <87edff3019.fsf@posteo.net> (message from Thierry Volpiatto on Thu, 21 Dec 2023 18:04:02 +0000)
> From: Thierry Volpiatto <thievol@posteo.net>
> Cc: monnier@iro.umontreal.ca, stefankangas@gmail.com, dmitry@gutov.dev,
> michael_heerdegen@web.de, 66394@debbugs.gnu.org
> Date: Thu, 21 Dec 2023 18:04:02 +0000
>
> > Thanks, I have a question:
> >
> > The doc string of register-use-preview says:
> >
> > This has no effect when the value of `register--read-with-preview-function'
> > is `register-read-with-preview-traditional'.
> >
> > However, customizing register-use-preview to the value 'traditional
> > has the exact effect of setting register--read-with-preview-function
> > to register-read-with-preview-traditional. OTOH, when
> > register-use-preview is set to 'traditional, one can set it to a
> > different value, and then the behavior will change. So I wonder what
> > that sentence is about and what I missed? Is that perhaps a leftover
> > from previous versions, and should now be deleted?
>
> Yes exactly, it can be deleted.
>
> > I updated the documentation and NEWS. I'd appreciate if you could
> > spare a few minutes to review the changes and point out any
> > inaccuracies or mistakes.
>
> About the documentation or register-use-preview in the manual:
>
> Another difference with the old behavior (traditional) is that the
> preview is filtered according to type of registers used by command. For
> example insert-register show only the registers that can be inserted,
> not windows, markers etc... Same for jump.
>
> - "Returns a function to format a register for previewing.
> -This according to the value of READ-PREVIEW-FUNCTION.")
> + "Return a function to format a register for previewing.
> +This is according to the value of `read-preview-function'.")
>
> Here READ-PREVIEW-FUNCTION is the argument of function and not a
> variable, so IMO it should be upcased and not quoted.
>
> (cl-defstruct register-preview-info
> "Store data for a specific register command.
> -TYPES are the types of register supported.
> -MSG is the minibuffer message to send when a register is selected.
> +TYPES are the supported types of registers.
> +MSG is the minibuffer message to show when a register is selected.
> ACT is the type of action the command is doing on register.
> -SMATCH accept a boolean value to say if command accept non matching register."
> +SMATCH accept a boolean value to say if the command accepts non-matching
> +registers."
> types msg act smatch noconfirm)
>
> NOCONFIRM is not documented (my fault).
> When set to nil don't request confirmation with RET.
>
> Otherwise all looks good to me, thanks.
Thanks, I fixed all of the above, and I'm therefore closing this bug.
next prev parent reply other threads:[~2023-12-23 10:49 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 19:03 bug#66394: 29.1; Make register-read-with-preview more useful Thierry Volpiatto
2023-10-08 6:45 ` bug#66394: [RE] " Thierry Volpiatto
2023-10-12 6:43 ` Thierry Volpiatto
2023-10-14 2:04 ` Richard Stallman
2023-10-14 5:59 ` Thierry Volpiatto
2023-10-16 2:04 ` Richard Stallman
2023-10-15 7:56 ` Thierry Volpiatto
2023-10-15 8:18 ` Stefan Kangas
2023-10-15 10:05 ` Thierry Volpiatto
2023-10-15 12:55 ` Stefan Kangas
2023-11-18 18:39 ` Thierry Volpiatto
2023-10-19 2:42 ` bug#66394: 29.1; " Michael Heerdegen
2023-10-19 6:16 ` Thierry Volpiatto
2023-10-20 5:00 ` Michael Heerdegen
2023-10-20 5:49 ` Thierry Volpiatto
2023-10-21 1:09 ` Michael Heerdegen
2023-10-21 3:34 ` Thierry Volpiatto
2023-10-23 4:09 ` Michael Heerdegen
2023-10-23 5:14 ` Thierry Volpiatto
2023-10-24 3:42 ` Michael Heerdegen
2023-10-24 3:54 ` Michael Heerdegen
2023-10-24 5:30 ` Thierry Volpiatto
2023-10-25 3:54 ` Michael Heerdegen
2023-10-24 7:19 ` Thierry Volpiatto
2023-10-25 4:10 ` Michael Heerdegen
2023-10-25 6:38 ` Thierry Volpiatto
2023-10-26 4:18 ` Michael Heerdegen
2023-10-26 6:17 ` Thierry Volpiatto
2023-10-27 1:27 ` Michael Heerdegen
2023-10-27 4:24 ` Thierry Volpiatto
2023-11-03 4:58 ` Michael Heerdegen
2023-11-19 19:37 ` Thierry Volpiatto
2023-11-20 6:00 ` Thierry Volpiatto
2023-11-20 17:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 18:51 ` Thierry Volpiatto
2023-11-25 10:23 ` Eli Zaretskii
2023-11-25 19:59 ` Thierry Volpiatto
2023-11-25 20:10 ` Eli Zaretskii
2023-11-25 21:14 ` Thierry Volpiatto
2023-11-26 10:38 ` Eli Zaretskii
2023-11-26 16:46 ` Thierry Volpiatto
2023-11-29 14:04 ` Eli Zaretskii
2023-11-29 18:18 ` Thierry Volpiatto
2023-11-30 6:00 ` Eli Zaretskii
2023-11-30 10:21 ` Thierry Volpiatto
2023-12-02 5:51 ` Thierry Volpiatto
2023-12-02 7:50 ` Eli Zaretskii
2023-12-02 8:08 ` Thierry Volpiatto
2023-12-03 14:35 ` Thierry Volpiatto
2023-12-03 15:05 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-03 16:48 ` Thierry Volpiatto
2023-12-03 18:29 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-03 18:39 ` Eli Zaretskii
2023-12-03 21:23 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-04 7:30 ` Thierry Volpiatto
2023-12-04 7:57 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-11 6:55 ` Thierry Volpiatto
2023-12-11 9:30 ` Thierry Volpiatto
2023-12-11 9:58 ` Thierry Volpiatto
2023-12-11 12:30 ` Eli Zaretskii
2023-12-11 13:10 ` Thierry Volpiatto
2023-12-11 17:32 ` Thierry Volpiatto
2023-12-11 23:36 ` Dmitry Gutov
2023-12-12 6:29 ` Thierry Volpiatto
2023-12-12 9:31 ` Thierry Volpiatto
2023-12-12 10:16 ` Thierry Volpiatto
2023-12-12 16:44 ` Thierry Volpiatto
2023-12-14 1:46 ` Dmitry Gutov
2023-12-14 5:34 ` Thierry Volpiatto
2023-12-14 7:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-14 8:24 ` Eli Zaretskii
2023-12-14 7:44 ` Eli Zaretskii
2023-12-14 15:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-14 17:58 ` Thierry Volpiatto
2023-12-14 19:19 ` Andreas Schwab
2023-12-14 20:29 ` Stefan Kangas
2023-12-15 14:45 ` Thierry Volpiatto
2023-12-15 15:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-15 18:36 ` Thierry Volpiatto
2023-12-15 23:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 13:18 ` Thierry Volpiatto
2023-12-16 15:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 20:39 ` Thierry Volpiatto
2023-12-17 23:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 5:15 ` Thierry Volpiatto
2023-12-18 13:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 18:11 ` Thierry Volpiatto
2023-12-18 18:22 ` Dmitry Gutov
2023-12-18 6:18 ` Thierry Volpiatto
2023-12-19 17:40 ` Thierry Volpiatto
2023-12-19 17:47 ` Thierry Volpiatto
2023-12-20 12:05 ` Eli Zaretskii
2023-12-20 17:23 ` Thierry Volpiatto
2023-12-21 11:47 ` Eli Zaretskii
2023-12-21 18:04 ` Thierry Volpiatto
2023-12-23 10:49 ` Eli Zaretskii [this message]
2023-12-16 15:07 ` Dmitry Gutov
2023-12-16 20:20 ` Thierry Volpiatto
2023-12-16 23:28 ` Dmitry Gutov
2023-12-14 2:10 ` Dmitry Gutov
2023-12-14 5:30 ` Thierry Volpiatto
2023-12-14 19:39 ` Stefan Kangas
2023-12-12 6:06 ` Alfred M. Szmidt
2023-12-12 9:37 ` Steve Perry via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-12 12:15 ` Eli Zaretskii
2023-12-12 17:58 ` Steve Perry via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-25 21:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-02 9:24 ` Bastien
2023-12-02 9:52 ` Thierry Volpiatto
2023-12-02 10:37 ` Bastien Guerry
2023-12-02 10:54 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-02 11:55 ` Thierry Volpiatto
2023-12-02 12:43 ` Thierry Volpiatto
2023-12-02 13:02 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-02 13:50 ` Bastien Guerry
2023-12-02 15:01 ` Thierry Volpiatto
2023-12-05 7:34 ` Tino Calancha
2023-12-05 7:38 ` Tino Calancha
2023-12-05 7:43 ` Tino Calancha
2023-12-12 5:46 ` Pedro Andres Aranda Gutierrez
2023-12-12 12:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835y0pdwib.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66394-done@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
--cc=stefankangas@gmail.com \
--cc=thievol@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.