From: Jim Porter <jporterbugs@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: 71605@debbugs.gnu.org
Subject: bug#71605: 30.0.50; [PATCH] Support variable-width text in 'visual-wrap-prefix-mode'
Date: Mon, 17 Jun 2024 09:13:38 -0700 [thread overview]
Message-ID: <835c7897-d276-b0fe-6d1e-8e6a20cac2bb@gmail.com> (raw)
In-Reply-To: <s54cyof3ayi.fsf@yahoo.com>
On 6/17/2024 7:23 AM, Po Lu via Bug reports for GNU Emacs, the Swiss
army knife of text editors wrote:
> Actually, there's more than just this one problem. To start with, the
> existing format of the generated line prefix properties enables the
> extracted fill prefix to be displayed consistently on any frame,
> whatever the metrics of its default font/face. This I consider a far
> more critical capability than perfect alignment of wrapped text in the
> presence of a variable-pitch default font, as the latter is virtually
> unknown among programmers, and also unimplementable within reasonable
> standards of performance with pixelwise spacers.
That's a good point. In practice, we should only do this if the
first-line prefix uses a variable-pitch font, since otherwise we might
as well just use the requisite number of space characters as before,
sans display-spec.
> If this is to be
> installed, please condition it behind a user option and restore the
> existing logic that you have effaced as the default.
I'll add a check for variable-pitch fonts and a user option. With the
variable-pitch check, I think it should be ok for the user option to
default to enabling this new behavior? For fixed-pitch fonts, the new
code would behave the same as before regardless of the option.
Note that I haven't removed any of the old logic though; it's all there
as before, since the space characters are useful for terminals (where
the pixelwise :width display-spec doesn't do anything for us, if I
understand correctly). I did extract parts of 'fill-content-prefix' into
'visual-wrap--content-prefix', but the only parts I removed were the
ones for handling multiple lines; those don't apply here, since
'visual-wrap-prefix-function' gets the prefixes one line at a time.
next prev parent reply other threads:[~2024-06-17 16:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 2:56 bug#71605: 30.0.50; [PATCH] Support variable-width text in 'visual-wrap-prefix-mode' Jim Porter
2024-06-17 11:37 ` Eli Zaretskii
2024-06-17 17:42 ` Jim Porter
2024-06-17 18:20 ` Eli Zaretskii
2024-06-17 18:44 ` Jim Porter
2024-06-18 11:37 ` Eli Zaretskii
2024-06-18 22:17 ` Jim Porter
2024-06-19 11:45 ` Eli Zaretskii
2024-06-19 19:53 ` Jim Porter
2024-06-20 4:58 ` Eli Zaretskii
2024-06-20 5:37 ` Jim Porter
2024-06-20 9:58 ` Eli Zaretskii
2024-06-20 17:36 ` Jim Porter
2024-06-20 18:08 ` Eli Zaretskii
2024-06-20 19:01 ` Jim Porter
2024-07-28 4:53 ` Jim Porter
2024-08-02 7:27 ` Eli Zaretskii
2024-08-04 19:24 ` Jim Porter
2024-06-17 14:23 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-17 16:13 ` Jim Porter [this message]
2024-06-17 18:17 ` Jim Porter
2024-06-17 19:55 ` Eli Zaretskii
2024-06-17 20:08 ` Jim Porter
2024-06-18 3:02 ` Jim Porter
2024-06-18 6:27 ` Jim Porter
2024-06-18 12:53 ` Eli Zaretskii
2024-06-18 12:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835c7897-d276-b0fe-6d1e-8e6a20cac2bb@gmail.com \
--to=jporterbugs@gmail.com \
--cc=71605@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.