From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#2993: 23.0.92; posn-col-row wrong with line-spacing in terminals Date: Tue, 14 Apr 2009 14:32:33 +0300 Message-ID: <834owro4ha.fsf@gnu.org> References: Reply-To: Eli Zaretskii , 2993@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1239709450 13444 80.91.229.12 (14 Apr 2009 11:44:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Apr 2009 11:44:10 +0000 (UTC) To: Nikolaj Schumacher , 2993@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 14 13:45:29 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Lth4y-0006Sm-Iw for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Apr 2009 13:45:28 +0200 Original-Received: from localhost ([127.0.0.1]:52055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lth3Z-0003NP-N4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Apr 2009 07:44:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lth3V-0003NH-OT for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 07:43:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lth3R-0003Mt-D9 for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 07:43:57 -0400 Original-Received: from [199.232.76.173] (port=53204 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lth3R-0003Mp-5x for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 07:43:53 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:38186) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lth3Q-0007hv-H6 for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 07:43:52 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3EBho04032009; Tue, 14 Apr 2009 04:43:50 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n3EBe5m6030955; Tue, 14 Apr 2009 04:40:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Eli Zaretskii Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 14 Apr 2009 11:40:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2993 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2993-submit@emacsbugs.donarmstrong.com id=B2993.123970876129196 (code B ref 2993); Tue, 14 Apr 2009 11:40:05 +0000 Original-Received: (at 2993) by emacsbugs.donarmstrong.com; 14 Apr 2009 11:32:41 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mtaout5.012.net.il (mtaout5.012.net.il [84.95.2.13]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3EBWXpK029185 for <2993@emacsbugs.donarmstrong.com>; Tue, 14 Apr 2009 04:32:35 -0700 Original-Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il (HyperSendmail v2004.12) id <0KI3007009CEOR00@i_mtaout5.012.net.il> for 2993@emacsbugs.donarmstrong.com; Tue, 14 Apr 2009 14:32:27 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.126.225.211]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KI300JVB9E2P011@i_mtaout5.012.net.il>; Tue, 14 Apr 2009 14:32:27 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 14 Apr 2009 07:43:57 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27161 Archived-At: > From: Nikolaj Schumacher > Date: Tue, 14 Apr 2009 13:11:55 +0200 > Cc: > > posn-col-row uses the `line-spacing' value in terminals. According to the > doc `line-spacing' only has an effect in window systems. You mean, on graphic displays. > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -934,7 +934,8 @@ and `event-end' functions." > (y (/ (cdr pair) (+ (frame-char-height frame) > (or (frame-parameter frame 'line-spacing) > ;; FIXME: Why the `default'? > - (default-value 'line-spacing) > + (when (window-system frame) > + (default-value 'line-spacing)) > 0))))) > (cons x y)))))) Please use `display-graphic-p' rather than assuming that if `window-system' is non-nil, the display is necessarily a graphic one. At least one Emacs configuration violates this assumption.