From: Eli Zaretskii <eliz@gnu.org>
To: Nikolaj Schumacher <me@nschum.de>, 2993@emacsbugs.donarmstrong.com
Subject: bug#2993: 23.0.92; posn-col-row wrong with line-spacing in terminals
Date: Tue, 14 Apr 2009 14:32:33 +0300 [thread overview]
Message-ID: <834owro4ha.fsf@gnu.org> (raw)
In-Reply-To: <m28wm31ock.fsf@nschum.de>
> From: Nikolaj Schumacher <me@nschum.de>
> Date: Tue, 14 Apr 2009 13:11:55 +0200
> Cc:
>
> posn-col-row uses the `line-spacing' value in terminals. According to the
> doc `line-spacing' only has an effect in window systems.
You mean, on graphic displays.
> --- a/lisp/subr.el
> +++ b/lisp/subr.el
> @@ -934,7 +934,8 @@ and `event-end' functions."
> (y (/ (cdr pair) (+ (frame-char-height frame)
> (or (frame-parameter frame 'line-spacing)
> ;; FIXME: Why the `default'?
> - (default-value 'line-spacing)
> + (when (window-system frame)
> + (default-value 'line-spacing))
> 0)))))
> (cons x y))))))
Please use `display-graphic-p' rather than assuming that if
`window-system' is non-nil, the display is necessarily a graphic one.
At least one Emacs configuration violates this assumption.
next prev parent reply other threads:[~2009-04-14 11:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ab6hbknp.fsf@cyd.mit.edu>
2009-04-14 11:11 ` bug#2993: 23.0.92; posn-col-row wrong with line-spacing in terminals Nikolaj Schumacher
2009-04-14 11:32 ` Eli Zaretskii [this message]
2009-04-14 12:12 ` Nikolaj Schumacher
2009-04-14 13:59 ` Eli Zaretskii
2009-04-17 17:37 ` how to use graphic-display-p and window-system Drew Adams
2009-04-17 18:15 ` Eli Zaretskii
2009-04-17 20:15 ` Drew Adams
2009-04-17 23:54 ` Stefan Monnier
2009-04-18 0:19 ` Drew Adams
2009-04-18 3:41 ` Stefan Monnier
2009-04-18 4:25 ` Drew Adams
2009-04-18 0:21 ` Miles Bader
2009-04-18 3:43 ` Stefan Monnier
2009-04-18 4:24 ` Drew Adams
2009-04-18 5:11 ` Miles Bader
2009-04-18 6:34 ` Eli Zaretskii
2009-04-18 7:01 ` Eli Zaretskii
2009-04-15 22:50 ` bug#2993: marked as done (23.0.92; posn-col-row wrong with line-spacing in terminals) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834owro4ha.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=2993@emacsbugs.donarmstrong.com \
--cc=me@nschum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.