From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Redundant if clause in xdisp.c? Date: Sat, 29 Aug 2009 20:40:19 +0300 Message-ID: <834orqbjss.fsf@gnu.org> References: <8363c6bxef.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1251567631 18636 80.91.229.12 (29 Aug 2009 17:40:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Aug 2009 17:40:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 29 19:40:24 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MhRuY-0006g4-L3 for ged-emacs-devel@m.gmane.org; Sat, 29 Aug 2009 19:40:22 +0200 Original-Received: from localhost ([127.0.0.1]:38598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhRuX-0003Ev-Ib for ged-emacs-devel@m.gmane.org; Sat, 29 Aug 2009 13:40:21 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MhRuS-0003Eg-GO for emacs-devel@gnu.org; Sat, 29 Aug 2009 13:40:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MhRuR-0003DP-G5 for emacs-devel@gnu.org; Sat, 29 Aug 2009 13:40:16 -0400 Original-Received: from [199.232.76.173] (port=56318 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhRuR-0003DD-DH for emacs-devel@gnu.org; Sat, 29 Aug 2009 13:40:15 -0400 Original-Received: from mtaout3.012.net.il ([84.95.2.7]:14512) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MhRuQ-0006EN-T1 for emacs-devel@gnu.org; Sat, 29 Aug 2009 13:40:15 -0400 Original-Received: from conversion-daemon.i_mtaout3.012.net.il by i_mtaout3.012.net.il (HyperSendmail v2004.12) id <0KP500J00FJGUB00@i_mtaout3.012.net.il> for emacs-devel@gnu.org; Sat, 29 Aug 2009 20:40:13 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.228.144.38]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KP500E0VFR0HW20@i_mtaout3.012.net.il>; Sat, 29 Aug 2009 20:40:13 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:114841 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Sat, 29 Aug 2009 11:50:39 -0400 > > > Okay to remove the condition and to collapse both branches into a > > single code fragment? > > Looks like a good idea, yes. Done. > BTW, before playing with the redisplay, please just throw away > keyboard.c's handling of self-insert-command, forward-char and > backward-char, as well as the corresponding "direct-rendering > fast-path" code. These optimizations are disabled for bidi redisplay anyway, so they don't bother me. > These optimizations seem to be pointless nowadays: even when running > Emacs-23 on my cell-phone (FreeRunner) displaying on my desktop, they > don't make any noticeable difference. How did you turn them off to measure their influence, and with what kind of stuff in your buffer(s)? > I refrained from installing this change for Emacs-23.2, out of fear > bigfoot might come and bite me, but I'll definitely install it for > Emacs-24. OK, but for now I'd prefer not to do any changes in my bidi sandbox that are not strictly related to bidirectional editing. Once we have a way to commit these changes to CVS, fine with me, if we are sure these optimizations don't matter anymore.