From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Redundant if clause in xdisp.c?
Date: Sat, 29 Aug 2009 20:40:19 +0300 [thread overview]
Message-ID: <834orqbjss.fsf@gnu.org> (raw)
In-Reply-To: <jwv8wh239oy.fsf-monnier+emacs@gnu.org>
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sat, 29 Aug 2009 11:50:39 -0400
>
> > Okay to remove the condition and to collapse both branches into a
> > single code fragment?
>
> Looks like a good idea, yes.
Done.
> BTW, before playing with the redisplay, please just throw away
> keyboard.c's handling of self-insert-command, forward-char and
> backward-char, as well as the corresponding "direct-rendering
> fast-path" code.
These optimizations are disabled for bidi redisplay anyway, so they
don't bother me.
> These optimizations seem to be pointless nowadays: even when running
> Emacs-23 on my cell-phone (FreeRunner) displaying on my desktop, they
> don't make any noticeable difference.
How did you turn them off to measure their influence, and with what
kind of stuff in your buffer(s)?
> I refrained from installing this change for Emacs-23.2, out of fear
> bigfoot might come and bite me, but I'll definitely install it for
> Emacs-24.
OK, but for now I'd prefer not to do any changes in my bidi sandbox
that are not strictly related to bidirectional editing. Once we have
a way to commit these changes to CVS, fine with me, if we are sure
these optimizations don't matter anymore.
next prev parent reply other threads:[~2009-08-29 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 12:46 Redundant if clause in xdisp.c? Eli Zaretskii
2009-08-29 14:16 ` Chong Yidong
2009-08-29 15:50 ` Stefan Monnier
2009-08-29 17:40 ` Eli Zaretskii [this message]
2009-08-29 21:21 ` Stefan Monnier
2009-08-30 18:06 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834orqbjss.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.