From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: 64-bit compilation and printfs Date: Mon, 12 Oct 2009 06:03:52 +0200 Message-ID: <834oq5jm1j.fsf@gnu.org> References: <4CE21A3C-B51B-45ED-B51B-86072D403E25@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1255320137 20141 80.91.229.12 (12 Oct 2009 04:02:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 12 Oct 2009 04:02:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 12 06:02:07 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MxC6p-0002Nf-7Z for ged-emacs-devel@m.gmane.org; Mon, 12 Oct 2009 06:02:07 +0200 Original-Received: from localhost ([127.0.0.1]:47908 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MxC6o-0000iq-63 for ged-emacs-devel@m.gmane.org; Mon, 12 Oct 2009 00:02:06 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MxC6h-0000id-VA for emacs-devel@gnu.org; Mon, 12 Oct 2009 00:02:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MxC6f-0000iJ-JX for emacs-devel@gnu.org; Mon, 12 Oct 2009 00:01:57 -0400 Original-Received: from [199.232.76.173] (port=38564 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MxC6f-0000iG-Ao for emacs-devel@gnu.org; Mon, 12 Oct 2009 00:01:57 -0400 Original-Received: from mtaout4.012.net.il ([84.95.2.10]:59136 helo=mtaout3.012.net.il) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MxC6e-0007Ys-O8 for emacs-devel@gnu.org; Mon, 12 Oct 2009 00:01:56 -0400 Original-Received: from conversion-daemon.i_mtaout3.012.net.il by i_mtaout3.012.net.il (HyperSendmail v2004.12) id <0KRD00500V3A1200@i_mtaout3.012.net.il> for emacs-devel@gnu.org; Mon, 12 Oct 2009 06:01:55 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.70.84.229]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KRD0013DV76MQ90@i_mtaout3.012.net.il>; Mon, 12 Oct 2009 06:01:55 +0200 (IST) In-reply-to: <4CE21A3C-B51B-45ED-B51B-86072D403E25@gmail.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:116094 Archived-At: > From: Adrian Robert > Date: Sun, 11 Oct 2009 20:46:27 -0400 > > In the course of getting the NS port compiling in 64-bit mode, some > other developers and myself discovered some format - arg mismatches in > printfs. XINT and XUINT return EMACS_INT which can be a long under > LP64. I'd like to replace places that use %d in the code with %ld, > and cast the argument to (long) to avoid issues in 32-bit mode. This > has been checked in for the NS port; the patch attached here does this > in common code. Does anyone think this should be done differently? > Else I'll check it in as well. This is OK, but please note that you seem to have local changes in xdisp.c unrelated to the %d issue (see below). Please don't accidentally check them in as well. > --- xdisp.c 10 Oct 2009 16:39:05 -0000 1.1313 > +++ xdisp.c 12 Oct 2009 00:41:06 -0000 > @@ -14128,11 +14128,13 @@ try_window_reusing_current_matrix (w) > return 0; > > /* Can't do this if region may have changed. */ > + /* > if ((!NILP (Vtransient_mark_mode) > && !NILP (current_buffer->mark_active)) > || !NILP (w->region_showing) > || !NILP (Vshow_trailing_whitespace)) > return 0; > + */ > > /* If top-line visibility has changed, give up. */ > if (WINDOW_WANTS_HEADER_LINE_P (w) > @@ -23605,6 +23607,9 @@ note_mouse_highlight (f, x, y) > if (! EQ (window, dpyinfo->mouse_face_window) > || (part != ON_TEXT && part != ON_MODE_LINE && part != ON_HEADER_LINE > && !NILP (dpyinfo->mouse_face_window))) > +/* if ((! EQ (window, dpyinfo->mouse_face_window) > + || (part != ON_TEXT && part != ON_MODE_LINE && part != ON_HEADER_LINE)) > + && !NILP (dpyinfo->mouse_face_window))*/ > clear_mouse_face (dpyinfo);