From: Eli Zaretskii <eliz@gnu.org>
To: Adrian Robert <adrian.b.robert@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: 64-bit compilation and printfs
Date: Mon, 12 Oct 2009 06:03:52 +0200 [thread overview]
Message-ID: <834oq5jm1j.fsf@gnu.org> (raw)
In-Reply-To: <4CE21A3C-B51B-45ED-B51B-86072D403E25@gmail.com>
> From: Adrian Robert <adrian.b.robert@gmail.com>
> Date: Sun, 11 Oct 2009 20:46:27 -0400
>
> In the course of getting the NS port compiling in 64-bit mode, some
> other developers and myself discovered some format - arg mismatches in
> printfs. XINT and XUINT return EMACS_INT which can be a long under
> LP64. I'd like to replace places that use %d in the code with %ld,
> and cast the argument to (long) to avoid issues in 32-bit mode. This
> has been checked in for the NS port; the patch attached here does this
> in common code. Does anyone think this should be done differently?
> Else I'll check it in as well.
This is OK, but please note that you seem to have local changes in
xdisp.c unrelated to the %d issue (see below). Please don't
accidentally check them in as well.
> --- xdisp.c 10 Oct 2009 16:39:05 -0000 1.1313
> +++ xdisp.c 12 Oct 2009 00:41:06 -0000
> @@ -14128,11 +14128,13 @@ try_window_reusing_current_matrix (w)
> return 0;
>
> /* Can't do this if region may have changed. */
> + /*
> if ((!NILP (Vtransient_mark_mode)
> && !NILP (current_buffer->mark_active))
> || !NILP (w->region_showing)
> || !NILP (Vshow_trailing_whitespace))
> return 0;
> + */
>
> /* If top-line visibility has changed, give up. */
> if (WINDOW_WANTS_HEADER_LINE_P (w)
> @@ -23605,6 +23607,9 @@ note_mouse_highlight (f, x, y)
> if (! EQ (window, dpyinfo->mouse_face_window)
> || (part != ON_TEXT && part != ON_MODE_LINE && part != ON_HEADER_LINE
> && !NILP (dpyinfo->mouse_face_window)))
> +/* if ((! EQ (window, dpyinfo->mouse_face_window)
> + || (part != ON_TEXT && part != ON_MODE_LINE && part != ON_HEADER_LINE))
> + && !NILP (dpyinfo->mouse_face_window))*/
> clear_mouse_face (dpyinfo);
next prev parent reply other threads:[~2009-10-12 4:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 0:46 64-bit compilation and printfs Adrian Robert
2009-10-12 4:03 ` Eli Zaretskii [this message]
2009-10-12 14:44 ` Adrian Robert
2009-10-12 8:48 ` Andreas Schwab
2009-10-13 19:34 ` Stefan Monnier
2009-10-14 16:40 ` Dan Nicolaescu
2009-10-14 17:50 ` Adrian Robert
2009-10-14 18:17 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834oq5jm1j.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=adrian.b.robert@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.