From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 23.1.93 pretest Date: Sun, 28 Feb 2010 19:15:10 +0200 Message-ID: <834ol1cme9.fsf@gnu.org> References: <87pr3rny7e.fsf@stupidchicken.com> <83fx4n122q.fsf@gnu.org> <833a0ndlo0.fsf@gnu.org> <83vddidh73.fsf@gnu.org> <83hbp2cxgx.fsf@gnu.org> <87aauugy1g.fsf@stupidchicken.com> <83eik6co9l.fsf@gnu.org> <87mxyuyvxy.fsf@stupidchicken.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1267377554 20546 80.91.229.12 (28 Feb 2010 17:19:14 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 28 Feb 2010 17:19:14 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 28 18:19:09 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NlmnM-00051g-QP for ged-emacs-devel@m.gmane.org; Sun, 28 Feb 2010 18:19:09 +0100 Original-Received: from localhost ([127.0.0.1]:33616 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nlmk6-0004zh-QB for ged-emacs-devel@m.gmane.org; Sun, 28 Feb 2010 12:15:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nlmk0-0004zS-Bj for emacs-devel@gnu.org; Sun, 28 Feb 2010 12:15:40 -0500 Original-Received: from [140.186.70.92] (port=53080 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nlmjy-0004zK-Jx for emacs-devel@gnu.org; Sun, 28 Feb 2010 12:15:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nlmjx-0000Vl-SK for emacs-devel@gnu.org; Sun, 28 Feb 2010 12:15:38 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:55608) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nlmjx-0000Vg-KE for emacs-devel@gnu.org; Sun, 28 Feb 2010 12:15:37 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KYK00A00AAHQH00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sun, 28 Feb 2010 19:15:02 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.70.17.203]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KYK006D2AL0KOA0@a-mtaout20.012.net.il>; Sun, 28 Feb 2010 19:15:02 +0200 (IST) In-reply-to: <87mxyuyvxy.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121471 Archived-At: > From: Chong Yidong > Cc: emacs-devel@gnu.org > Date: Sat, 27 Feb 2010 20:45:45 -0500 > > Eli Zaretskii writes: > > >> Hmm, this is strange. This change (actually the succeeding 2010-02-06 > >> change to the same place) switches from using alloca to SAFE_ALLOCA > >> (i.e. malloc, since the desired structure is large). But the only way I > >> can see for this code to crash is if load_charset_map somehow makes a > >> pointer into the allocated structure. But in that case, the old alloca > >> case should have crashed too. > > > > Yes, it _is_ weird. But the effect (see below) does look like we are > > freeing memory being used, or maybe overwriting some allocated buffer, > > or in some other way thrashing the arena. > > Hmm, I think I may see the problem. Does this patch help? No, it doesn't :-(