From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs 23.1.93 pretest Date: Tue, 02 Mar 2010 20:15:14 +0200 Message-ID: <834oky4mkt.fsf@gnu.org> References: <87pr3rny7e.fsf@stupidchicken.com> <83fx4n122q.fsf@gnu.org> <833a0ndlo0.fsf@gnu.org> <83vddidh73.fsf@gnu.org> <83hbp2cxgx.fsf@gnu.org> <87aauugy1g.fsf@stupidchicken.com> <83eik6co9l.fsf@gnu.org> <87mxyuyvxy.fsf@stupidchicken.com> <87fx4l8mkf.fsf@stupidchicken.com> <831vg5cll1.fsf@gnu.org> <83pr3pb1iu.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1267553773 32285 80.91.229.12 (2 Mar 2010 18:16:13 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 2 Mar 2010 18:16:13 +0000 (UTC) To: cyd@stupidchicken.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 02 19:16:08 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NmWdV-0006lp-Lg for ged-emacs-devel@m.gmane.org; Tue, 02 Mar 2010 19:16:01 +0100 Original-Received: from localhost ([127.0.0.1]:53957 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NmWdU-00028a-TH for ged-emacs-devel@m.gmane.org; Tue, 02 Mar 2010 13:16:00 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NmWcd-00023n-VK for emacs-devel@gnu.org; Tue, 02 Mar 2010 13:15:08 -0500 Original-Received: from [140.186.70.92] (port=41923 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NmWcc-00023K-3a for emacs-devel@gnu.org; Tue, 02 Mar 2010 13:15:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NmWcb-0005sG-5j for emacs-devel@gnu.org; Tue, 02 Mar 2010 13:15:06 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:63000) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NmWca-0005s9-VK for emacs-devel@gnu.org; Tue, 02 Mar 2010 13:15:05 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0KYO00H000QJ1N00@a-mtaout23.012.net.il> for emacs-devel@gnu.org; Tue, 02 Mar 2010 20:15:03 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.228.54.31]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KYO00FF22P1XJ90@a-mtaout23.012.net.il>; Tue, 02 Mar 2010 20:15:02 +0200 (IST) In-reply-to: <83pr3pb1iu.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121559 Archived-At: > Date: Sun, 28 Feb 2010 21:31:21 +0200 > From: Eli Zaretskii > Cc: > > So I think the change in charset.c itself did not cause the bug, it > just exposed a bug elsewhere, because it reshuffles the heap. Actually, it turns out it's not ``reshuffling the heap'' that triggers the bug, but rather the fact that when we call xmalloc, Emacs might relocate buffer text. IOW, I found the reason for the bug. One of the callers of load_charset_map_from_file maintains pointers into buffer text, so when that gets relocated, ... you get the idea. The first naive attempt to solve it was unsuccessful, so there's probably something else at work here. Hmm...