From: Eli Zaretskii <eliz@gnu.org>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: Buffer size limitation in insdel.c
Date: Fri, 24 Sep 2010 16:28:01 +0200 [thread overview]
Message-ID: <834odftdvy.fsf@gnu.org> (raw)
In-Reply-To: <E1Oz8xf-0005ov-RR@fencepost.gnu.org>
> From: Richard Stallman <rms@gnu.org>
> CC: emacs-devel@gnu.org
> Date: Fri, 24 Sep 2010 10:09:15 -0400
>
> It hides bugs, if nothing else.
>
> Could you please explain what you mean? Usually an error check does
> not hide bugs; rather, it catches them early.
Ah, but this is not an error check. This code prevents us from using
buffers larger than what a 32-bit int can cover, i.e. 2GB. By
contrast, an Emacs integer is a 64-bit type on 64-bit machines, so we
could potentially have much larger buffers there.
The reason for this code is that many places use an int to hold buffer
positions. All these places are bugs; they should use EMACS_INT
instead. This code hides those bugs.
next prev parent reply other threads:[~2010-09-24 14:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 12:06 Buffer size limitation in insdel.c Eli Zaretskii
2010-09-22 12:12 ` Lars Magne Ingebrigtsen
2010-09-22 15:20 ` Eli Zaretskii
2010-09-22 12:16 ` David Kastrup
2010-09-23 0:06 ` Stefan Monnier
2010-09-23 0:58 ` Richard Stallman
2010-09-23 7:55 ` Eli Zaretskii
2010-09-23 9:23 ` Leo
2010-09-23 9:30 ` Eli Zaretskii
2010-09-23 10:59 ` Lars Magne Ingebrigtsen
2010-09-23 12:15 ` Eli Zaretskii
2010-09-23 12:18 ` Lars Magne Ingebrigtsen
2010-09-23 12:47 ` Lars Magne Ingebrigtsen
2010-09-23 13:12 ` Andreas Schwab
2010-09-23 13:22 ` Eli Zaretskii
2010-09-23 13:37 ` Lars Magne Ingebrigtsen
2010-09-23 14:13 ` Eli Zaretskii
2010-09-23 14:21 ` Lars Magne Ingebrigtsen
2010-09-23 14:31 ` Lars Magne Ingebrigtsen
2010-09-23 14:41 ` Eli Zaretskii
2010-09-23 14:49 ` Lars Magne Ingebrigtsen
2010-09-23 15:08 ` Lars Magne Ingebrigtsen
2010-09-23 18:56 ` Eli Zaretskii
2010-09-23 19:02 ` Lars Magne Ingebrigtsen
2010-09-23 19:22 ` Eli Zaretskii
2010-09-24 14:09 ` Richard Stallman
2010-09-24 14:28 ` Eli Zaretskii [this message]
2010-09-24 14:38 ` Lars Magne Ingebrigtsen
2010-09-25 13:55 ` Eli Zaretskii
2010-09-25 16:26 ` Lars Magne Ingebrigtsen
2010-09-25 16:38 ` Lars Magne Ingebrigtsen
2010-09-25 9:40 ` Richard Stallman
2010-09-25 10:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834odftdvy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.