From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Emacs-diffs Digest, Vol 94, Issue 89 Date: Sat, 25 Sep 2010 15:28:02 +0200 Message-ID: <834oderlzx.fsf@gnu.org> References: <83zkv7rmpe.fsf@gnu.org> <83iq1us2hx.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1285421299 7807 80.91.229.12 (25 Sep 2010 13:28:19 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 25 Sep 2010 13:28:19 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 25 15:28:18 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OzUnY-00014s-4T for ged-emacs-devel@m.gmane.org; Sat, 25 Sep 2010 15:28:18 +0200 Original-Received: from localhost ([127.0.0.1]:39881 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzUnU-0004gA-UL for ged-emacs-devel@m.gmane.org; Sat, 25 Sep 2010 09:28:12 -0400 Original-Received: from [140.186.70.92] (port=32791 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzUnM-0004fs-Oq for emacs-devel@gnu.org; Sat, 25 Sep 2010 09:28:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OzUnI-00054i-Os for emacs-devel@gnu.org; Sat, 25 Sep 2010 09:28:04 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:34955) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OzUnI-00054b-I9 for emacs-devel@gnu.org; Sat, 25 Sep 2010 09:28:00 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0L9B0010019FRS00@a-mtaout21.012.net.il> for emacs-devel@gnu.org; Sat, 25 Sep 2010 15:27:58 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.203.3]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L9B001WX1EJOE90@a-mtaout21.012.net.il>; Sat, 25 Sep 2010 15:27:56 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:130840 Archived-At: > From: Lars Magne Ingebrigtsen > Date: Sat, 25 Sep 2010 15:19:37 +0200 > > So in this case FRAME_LINES should cast to an int before returning? > Makes sense to me, and I can redo the stuff in that file based on that. > > Or just make these into ints: > > /* Size of this frame, excluding fringes, scroll bars etc., > in units of canonical characters. */ > EMACS_INT text_lines, text_cols; Given the controversy, I'll defer to Stefan and Chong for a definitive guidance. > Which reminds me about a question about characters. Can they really be > longs? AFAIK, characters in Emacs are presently 32-bit entities, so an int should suffice.