From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: oops? read/write vs type of length parameter Date: Mon, 11 Apr 2011 16:58:44 +0300 Message-ID: <834o64sxd7.fsf@gnu.org> References: <87wrj1jhfc.fsf@rho.meyering.net> <87hba5yq0p.fsf@uwakimon.sk.tsukuba.ac.jp> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1302530613 15092 80.91.229.12 (11 Apr 2011 14:03:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 11 Apr 2011 14:03:33 +0000 (UTC) Cc: jim@meyering.net, emacs-devel@gnu.org To: "Stephen J. Turnbull" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 11 16:03:29 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q9HiC-00077z-EI for ged-emacs-devel@m.gmane.org; Mon, 11 Apr 2011 16:03:28 +0200 Original-Received: from localhost ([127.0.0.1]:35223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q9Hfu-00048B-VH for ged-emacs-devel@m.gmane.org; Mon, 11 Apr 2011 10:01:07 -0400 Original-Received: from [140.186.70.92] (port=46973 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q9Hfg-00046N-Sr for emacs-devel@gnu.org; Mon, 11 Apr 2011 10:00:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q9Hfb-0000Ry-Ca for emacs-devel@gnu.org; Mon, 11 Apr 2011 10:00:48 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:55281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9Hfb-0000Rf-4z for emacs-devel@gnu.org; Mon, 11 Apr 2011 10:00:47 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LJH00E00QTPHA00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Mon, 11 Apr 2011 17:00:25 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.127.31.148]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LJH00DJSQWNRQ50@a-mtaout20.012.net.il>; Mon, 11 Apr 2011 17:00:24 +0300 (IDT) In-reply-to: <87hba5yq0p.fsf@uwakimon.sk.tsukuba.ac.jp> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:138390 Archived-At: > From: "Stephen J. Turnbull" > Cc: Jim Meyering , > emacs-devel@gnu.org > Date: Mon, 11 Apr 2011 20:40:54 +0900 > > > We call these functions with an argument of type EMACS_INT, > > If you're going to do that, why not declare it as an EMACS_INT? I actually considered that. The reasons I eventually decided against it are all minor: I hate to type-cast if I can avoid that, and I try to avoid passing to library functions data types that are different from what the header declares. The fact that it used to be `int' was also a minor factor. Finally, sysdep.c doesn't use EMACS_INT, except in one very special case, so it looked like using standard types was its "style". But these are all minor, so if people prefer EMACS_INT, I don't mind. > The problem with using external standard types is that some developers > will proceed to "correct" them "Correct" them to what and why?