From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r109685: Rely on to declare 'environ' Date: Mon, 20 Aug 2012 19:49:16 +0300 Message-ID: <834nnxcxv7.fsf@gnu.org> References: <83d32mclxb.fsf@gnu.org> <5031B79B.1090005@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1345481364 8235 80.91.229.3 (20 Aug 2012 16:49:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2012 16:49:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 18:49:25 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T3VAH-0001Yv-Th for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2012 18:49:22 +0200 Original-Received: from localhost ([::1]:42156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3VAG-000230-7m for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2012 12:49:20 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3VAD-00022p-T2 for emacs-devel@gnu.org; Mon, 20 Aug 2012 12:49:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3VAC-0007XM-RQ for emacs-devel@gnu.org; Mon, 20 Aug 2012 12:49:17 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:57897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3VAC-0007X4-Iu for emacs-devel@gnu.org; Mon, 20 Aug 2012 12:49:16 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0M9200C00C1S0800@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Mon, 20 Aug 2012 19:49:14 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M9200BT7C22VW20@a-mtaout20.012.net.il>; Mon, 20 Aug 2012 19:49:14 +0300 (IDT) In-reply-to: <5031B79B.1090005@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152699 Archived-At: > Date: Sun, 19 Aug 2012 21:05:47 -0700 > From: Paul Eggert > CC: emacs-devel@gnu.org > > On 08/19/2012 07:54 PM, Eli Zaretskii wrote: > > These parts of your changes seem to be wrong, or at least > > under-documented in ChangeLog: the Windows build does not use > > lib/unistd.h. > > On Windows, as I understand it, the system declares > 'environ', so gnulib doesn't need to do anything special. > > I'm getting this info from gnulib's unistd.h file. > It says that on Windows 'environ' is declared by > stdlib.h. But Emacs's config.h includes stdlib.h, so > 'environ' is always visible. > > I tried to clarify this by editing the ChangeLog in > trunk bzr 109688. Thanks. > If my understanding is wrong, my apologies, but the > point is that the main code should be able to assume that > "#include " followed by "#include " > declares 'environ', and if my analysis is incorrect and > that's not the case then I suggest adding > 'extern char **environ;' to nt/inc/unistd.h. No, your analysis is valid. I added some additional clarifications in ChangeLog and conf_post.h.