From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12632: file permissions checking mishandled when setuid Date: Tue, 23 Oct 2012 05:49:37 +0200 Message-ID: <834nlldezy.fsf@gnu.org> References: <5078CAB6.7020509@cs.ucla.edu> <83sj9g4vy7.fsf@gnu.org> <507BAA6C.2000601@cs.ucla.edu> <83lif74p78.fsf@gnu.org> <507C823D.40304@cs.ucla.edu> <83d30j3wqg.fsf@gnu.org> <507CF802.6000305@cs.ucla.edu> <83a9vm4bmv.fsf@gnu.org> <50818763.80501@cs.ucla.edu> <83wqymz4me.fsf@gnu.org> <5081A1DF.9000009@cs.ucla.edu> <5081ABD6.9060002@cs.ucla.edu> <23r4osd2f9.fsf@fencepost.gnu.org> <50836366.6080600@cs.ucla.edu> <5084E1B2.2020105@cs.ucla.edu> <83ipa2ctl2.fsf@gnu.org> <5085AD9E.7040701@cs.ucla.edu> <838vaycj65.fsf@gnu.org> <5085BB01.2030402@cs.ucla.edu> <5085F710.5050102@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1350964216 27048 80.91.229.3 (23 Oct 2012 03:50:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2012 03:50:16 +0000 (UTC) Cc: 12632@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 23 05:50:24 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TQVVX-0006FM-7x for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Oct 2012 05:50:23 +0200 Original-Received: from localhost ([::1]:50171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQVVP-0007Pj-Lg for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Oct 2012 23:50:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQVVN-0007Pe-7k for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 23:50:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQVVM-0006cQ-55 for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 23:50:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQVVM-0006cM-1K for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 23:50:12 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TQVX7-00039V-LJ for bug-gnu-emacs@gnu.org; Mon, 22 Oct 2012 23:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Oct 2012 03:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security patch Original-Received: via spool by 12632-submit@debbugs.gnu.org id=B12632.135096429912089 (code B ref 12632); Tue, 23 Oct 2012 03:52:01 +0000 Original-Received: (at 12632) by debbugs.gnu.org; 23 Oct 2012 03:51:39 +0000 Original-Received: from localhost ([127.0.0.1]:56654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQVWl-00038v-Ar for submit@debbugs.gnu.org; Mon, 22 Oct 2012 23:51:39 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:37941) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TQVWi-00038h-G5 for 12632@debbugs.gnu.org; Mon, 22 Oct 2012 23:51:37 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MCB00000UJYMP00@a-mtaout20.012.net.il> for 12632@debbugs.gnu.org; Tue, 23 Oct 2012 05:49:40 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MCB0005FUMRKG40@a-mtaout20.012.net.il>; Tue, 23 Oct 2012 05:49:40 +0200 (IST) In-reply-to: <5085F710.5050102@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65900 Archived-At: > Date: Mon, 22 Oct 2012 18:46:56 -0700 > From: Paul Eggert > CC: Eli Zaretskii , 12632@debbugs.gnu.org > > On 10/22/2012 05:40 PM, Stefan Monnier wrote: > >>> We use IS_DIRECTORY_SEP in other places, so why avoid it here? > >> > If it's not needed, it makes the code a bit harder to read. > > I don't see why. The name says very clearly what it is intended to do. > > On the contrary, it seems more clear than comparing with '/' which only > > makes sense if you happen to know that / is the special char used as > > directory-separator. > > Using IS_DIRECTORY_SEP indicates that it's necessary to > process a file name using a system-dependent interpretation > rather than the standard POSIX interpretation. When > plain X=='/' would do, it can mislead the reader if the code > does IS_DIRECTORY_SEP (X), as the reader may naturally (and > mistakenly) infer that the code was written that way because > it must treat '\' specially on Windows. Which is the case, so there's no misleading. > It's primarily this clarity, not the brevity, that I was referring > to. This argument is a waste of everybody's time. Feel free to leave the test as it is, I will fix that after you commit the changeset.