From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12805: 24.2.50; Cygw32 build break Date: Mon, 05 Nov 2012 18:38:40 +0200 Message-ID: <834nl43sz3.fsf@gnu.org> References: <87wqy0fjsa.wl%%xmue@d1.dion.ne.jp> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1352133619 18964 80.91.229.3 (5 Nov 2012 16:40:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Nov 2012 16:40:19 +0000 (UTC) Cc: 12805@debbugs.gnu.org To: Kazuhiro Ito , Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 05 17:40:28 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TVPiq-0000xD-O4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Nov 2012 17:40:24 +0100 Original-Received: from localhost ([::1]:48653 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVPih-00076V-QB for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Nov 2012 11:40:15 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVPiW-000728-JF for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2012 11:40:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TVPiO-0003qU-1C for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2012 11:40:03 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVPiN-0003qP-Tu for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2012 11:39:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TVPlN-0006Q2-Nz for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2012 11:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Nov 2012 16:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12805 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12805-submit@debbugs.gnu.org id=B12805.135213373124617 (code B ref 12805); Mon, 05 Nov 2012 16:43:01 +0000 Original-Received: (at 12805) by debbugs.gnu.org; 5 Nov 2012 16:42:11 +0000 Original-Received: from localhost ([127.0.0.1]:50772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVPkY-0006Oz-69 for submit@debbugs.gnu.org; Mon, 05 Nov 2012 11:42:11 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:36887) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TVPkV-0006Or-Ng for 12805@debbugs.gnu.org; Mon, 05 Nov 2012 11:42:09 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MD000500WW3HO00@a-mtaout20.012.net.il> for 12805@debbugs.gnu.org; Mon, 05 Nov 2012 18:38:45 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MD00045AWWLUO90@a-mtaout20.012.net.il>; Mon, 05 Nov 2012 18:38:45 +0200 (IST) In-reply-to: <87wqy0fjsa.wl%%xmue@d1.dion.ne.jp> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66484 Archived-At: > Date: Mon, 05 Nov 2012 19:04:05 +0900 > From: Kazuhiro Ito > > w32fns.c: In function 'emacs_abort': > w32fns.c:7763:8: warning: implicit declaration of function '_open_osfhandle' > w32fns.c:7765:8: warning: implicit declaration of function 'write' > w32fns.c:7766:6: warning: implicit declaration of function '_open' > w32fns.c:7769:3: warning: implicit declaration of function 'lseek' > w32fns.c:7794:8: warning: implicit declaration of function 'close' > (snip) > gcc -std=gnu99 -Demacs -I. -I/build/emacs/trunk/src -I../lib -I/build/emacs/trunk/src/../lib -I/usr/include/libxml2 -MMD -MF deps/.d -MP -I/usr/include/p11-kit-1 -g3 -O2 -L/usr/lib/noX \ > -o temacs pre-crt0.o dispnew.o frame.o scroll.o xdisp.o menu.o window.o charset.o coding.o category.o ccl.o character.o chartab.o bidi.o cm.o term.o terminal.o xfaces.o emacs.o keyboard.o macros.o keymap.o sysdep.o buffer.o filelock.o insdel.o marker.o minibuf.o fileio.o dired.o cmds.o casetab.o casefiddle.o indent.o search.o regex.o undo.o alloc.o data.o doc.o editfns.o callint.o eval.o floatfns.o fns.o font.o print.o lread.o syntax.o unexcw.o bytecode.o process.o gnutls.o callproc.o region-cache.o sound.o atimer.o doprnt.o intervals.o textprop.o composite.o xml.o profiler.o sheap.o cygw32.o w32fns.o w32menu.o w32reg.o w32font.o w32term.o w32xfns.o w32select.o w32uniscribe.o fontset.o fringe.o image.o terminfo.o gmalloc.o lastfile.o vm-limit.o ../lib/libgn u.a -lkernel32 -luser32 -lgdi32 -lole32 -lcomdlg32 -lusp10 -lcomctl32 -lwinspool -ltiff -ljpeg -lpng -lz -lm -lgif -lXpm -lxml2 -lz -liconv -lm -lncurses -L/usr/ > bin -lgnutls -lnettle -lhogweed -lgmp -ltasn1 -lp11-kit -lz -lpthread > w32fns.o: In function `emacs_abort': > /build/emacs/trunk/src/w32fns.c:7763: undefined reference to `__open_osfhandle' > collect2: ld returned 1 exit status > Makefile:632: recipe for target `temacs.exe' failed > make[1]: *** [temacs.exe] Error 1 > make[1]: Leaving directory `/build/emacs/trunk/src' > Makefile:334: recipe for target `src' failed > make: *** [src] Error 2 Sorry, I didn't expect cygw32 to use emacs_abort implementation on w32fns.c. Now I see this in sysdep.c: #ifndef HAVE_NTGUI void emacs_abort (void) { terminate_due_to_signal (SIGABRT, 10); } #endif I think I fixed the problem (in trunk revision 110806), please test, as I don't have Cygwin installed to test this myself. However, I don't understand why would the cygw32 build use the Windows abort dialog, when the Cygwin/X build uses the Posix facilities instead. The cygw32 is still a Cygwin program, so I think it would be confusing for Cygwin users to have such a radical change in behavior under fatal error. Daniel, is this an omission? If so, perhaps we should ifdef away for Cygwin the whole w32fns.c emacs_abort implementation, and replace HAVE_NTGUI above with WINDOWSNT. If this isn't an omission, I'd like to hear your reasons. TIA.