From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: dmantipov@yandex.ru, monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [RFC, PATCH] shrink struct vectorlike_header #2
Date: Tue, 06 Nov 2012 23:28:34 +0200 [thread overview]
Message-ID: <834nl22zgd.fsf@gnu.org> (raw)
In-Reply-To: <509978BF.6090905@cs.ucla.edu>
> Date: Tue, 06 Nov 2012 12:53:19 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
> Emacs development discussions <emacs-devel@gnu.org>
>
> > +/* Size of the struct buffer part beyond leading
> > + Lisp_Objects, in word_size units. */
> > +
> > +#define BUFFER_REST_SIZE \
> > + ((sizeof (struct buffer) - header_size) / word_size - BUFFER_LISP_SIZE)
>
> This assumes (sizeof (struct buffer) - header_size) is a
> multiple of word_size, but that's not necessarily the case.
Shouldn't this use offsetof for safer results?
next prev parent reply other threads:[~2012-11-06 21:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 6:41 [PATCH] shrink struct vectorlike_header Dmitry Antipov
2012-10-11 12:57 ` Stefan Monnier
2012-11-06 17:09 ` [RFC, PATCH] shrink struct vectorlike_header #2 Dmitry Antipov
2012-11-06 18:17 ` Stefan Monnier
2012-11-07 14:57 ` Dmitry Antipov
2012-11-08 3:08 ` Stefan Monnier
2012-11-08 5:25 ` Paul Eggert
2012-11-08 13:31 ` Dmitry Antipov
2012-11-08 14:03 ` Stefan Monnier
2012-11-08 14:45 ` Dmitry Antipov
2012-11-08 15:08 ` Dmitry Antipov
2012-11-08 16:30 ` Paul Eggert
2012-11-08 17:12 ` Andreas Schwab
2012-11-08 17:42 ` Nix
2012-11-09 18:04 ` Andreas Rottmann
2012-11-08 6:56 ` Stephen J. Turnbull
2012-11-06 20:53 ` Paul Eggert
2012-11-06 21:28 ` Eli Zaretskii [this message]
2012-10-11 16:42 ` [PATCH] shrink struct vectorlike_header Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834nl22zgd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.