From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12881: Assume at least POSIX.1-1988 for fcntl.h Date: Sun, 18 Nov 2012 18:58:45 +0200 Message-ID: <834nkm26gq.fsf@gnu.org> References: <50A34A56.9080007@cs.ucla.edu> <83y5i4t7gm.fsf@gnu.org> <50A48C67.7020603@cs.ucla.edu> <83ip96u5ic.fsf@gnu.org> <50A54B89.2080505@cs.ucla.edu> <83mwyhswqo.fsf@gnu.org> <50A80CEA.4030207@cs.ucla.edu> <83obiv1slh.fsf@gnu.org> <50A866F4.3070203@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1353258073 22841 80.91.229.3 (18 Nov 2012 17:01:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Nov 2012 17:01:13 +0000 (UTC) Cc: 12881@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 18 18:01:24 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ta8FH-0003C9-BF for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Nov 2012 18:01:23 +0100 Original-Received: from localhost ([::1]:42787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta8F5-0001DH-J2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Nov 2012 12:01:11 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:57935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta8F0-0001C9-Py for bug-gnu-emacs@gnu.org; Sun, 18 Nov 2012 12:01:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ta8Ex-0002lM-Nx for bug-gnu-emacs@gnu.org; Sun, 18 Nov 2012 12:01:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta8Ex-0002lE-Jy for bug-gnu-emacs@gnu.org; Sun, 18 Nov 2012 12:01:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Ta8Ft-0000CP-JT for bug-gnu-emacs@gnu.org; Sun, 18 Nov 2012 12:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Nov 2012 17:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12881 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12881-submit@debbugs.gnu.org id=B12881.1353258092725 (code B ref 12881); Sun, 18 Nov 2012 17:02:01 +0000 Original-Received: (at 12881) by debbugs.gnu.org; 18 Nov 2012 17:01:32 +0000 Original-Received: from localhost ([127.0.0.1]:53122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ta8FP-0000BV-Kt for submit@debbugs.gnu.org; Sun, 18 Nov 2012 12:01:31 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:57398) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ta8FM-0000BL-8B for 12881@debbugs.gnu.org; Sun, 18 Nov 2012 12:01:29 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MDP00H000ECWZ00@a-mtaout21.012.net.il> for 12881@debbugs.gnu.org; Sun, 18 Nov 2012 18:59:10 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MDP00HDI0ILQP80@a-mtaout21.012.net.il>; Sun, 18 Nov 2012 18:59:10 +0200 (IST) In-reply-to: <50A866F4.3070203@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-Spam-Score: 1.5 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-Spam-Score: 1.5 (+) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67125 Archived-At: > Date: Sat, 17 Nov 2012 20:41:24 -0800 > From: Paul Eggert > CC: 12881@debbugs.gnu.org > > On 11/17/2012 07:46 PM, Eli Zaretskii wrote: > > O_RDWR doesn't need to be defined > > (it is already defined by a Windows system header) > > OK, sorry, I misunderstood your earlier recommendation (to move > O_NOCTTY) to also refer to O_RDWR. If you like, I can easily > remove the unnecessary definition of O_RDWR in nt/inc/unistd.h. Thanks, I already did that. > > Looks like I invested all that effort in vain > > I don't see why here, either. Neither of these appear to be problems > that would break a build or cause Emacs to misbehave. And even if they > were, any fixes would be trivial. I tried for once to make this commit clean, not requiring any fixes at all. I hope in the future, if you decide to do things that affect the w32 build differently than what I suggest, we could discuss this first, especially if I already invested some effort into making the changes as clean as possible for Windows. TIA.