From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#16058: 24.3.50; X protocol error: BadAlloc... Date: Mon, 09 Dec 2013 20:15:14 +0200 Message-ID: <834n6hzya5.fsf@gnu.org> References: <8738m7vo9f.fsf@gmail.com> <52A02273.2030003@yandex.ru> <87y53zu62a.fsf@gmail.com> <52A16E14.9030007@yandex.ru> <87vbz274qt.fsf@gmail.com> <52A58102.6040907@yandex.ru> <838uvuynxv.fsf@gnu.org> <52A5F9D6.4000302@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1386612974 5795 80.91.229.3 (9 Dec 2013 18:16:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Dec 2013 18:16:14 +0000 (UTC) Cc: thierry.volpiatto@gmail.com, 16058@debbugs.gnu.org To: Dmitry Antipov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 09 19:16:18 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vq5NR-0001Mo-Hx for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Dec 2013 19:16:17 +0100 Original-Received: from localhost ([::1]:45316 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq5NQ-0006pI-Rn for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Dec 2013 13:16:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq5NH-0006dK-Ow for bug-gnu-emacs@gnu.org; Mon, 09 Dec 2013 13:16:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vq5NC-0007lc-E3 for bug-gnu-emacs@gnu.org; Mon, 09 Dec 2013 13:16:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vq5NC-0007lX-5F for bug-gnu-emacs@gnu.org; Mon, 09 Dec 2013 13:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vq5NB-00023T-NA for bug-gnu-emacs@gnu.org; Mon, 09 Dec 2013 13:16:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Dec 2013 18:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16058 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16058-submit@debbugs.gnu.org id=B16058.13866129247847 (code B ref 16058); Mon, 09 Dec 2013 18:16:01 +0000 Original-Received: (at 16058) by debbugs.gnu.org; 9 Dec 2013 18:15:24 +0000 Original-Received: from localhost ([127.0.0.1]:40505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vq5Ma-00022U-Bi for submit@debbugs.gnu.org; Mon, 09 Dec 2013 13:15:24 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:37042) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vq5MX-00022F-42 for 16058@debbugs.gnu.org; Mon, 09 Dec 2013 13:15:22 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MXJ00A00X2GMB00@a-mtaout20.012.net.il> for 16058@debbugs.gnu.org; Mon, 09 Dec 2013 20:15:16 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MXJ00AQ7XDFGB70@a-mtaout20.012.net.il>; Mon, 09 Dec 2013 20:15:16 +0200 (IST) In-reply-to: <52A5F9D6.4000302@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81654 Archived-At: > Date: Mon, 09 Dec 2013 21:11:50 +0400 > From: Dmitry Antipov > CC: thierry.volpiatto@gmail.com, 16058@debbugs.gnu.org > > >> + /* Don't extend on a previously drawn tool bar items (Bug#16058). */ > >> + row->enabled_p = 0; > >> prepare_desired_row (row); > >> row->y = it->current_y; > > > > Isn't it better to just call clear_glyph_row explicitly? > > Hm...not sure, what about enabling enabled_p You can do that by hand. > and preserving reversed_p? We don't support R2L toolbars anyway, there's a comment about that in the code. Anyway, if you prefer to do this your way, we should have a comment there saying that disabling the row ensures prepare_desired_row will clear it. > And, of course, thanks for reviewing it. You are welcome.