From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: thierry.volpiatto@gmail.com, 16058@debbugs.gnu.org
Subject: bug#16058: 24.3.50; X protocol error: BadAlloc...
Date: Mon, 09 Dec 2013 20:15:14 +0200 [thread overview]
Message-ID: <834n6hzya5.fsf@gnu.org> (raw)
In-Reply-To: <52A5F9D6.4000302@yandex.ru>
> Date: Mon, 09 Dec 2013 21:11:50 +0400
> From: Dmitry Antipov <dmantipov@yandex.ru>
> CC: thierry.volpiatto@gmail.com, 16058@debbugs.gnu.org
>
> >> + /* Don't extend on a previously drawn tool bar items (Bug#16058). */
> >> + row->enabled_p = 0;
> >> prepare_desired_row (row);
> >> row->y = it->current_y;
> >
> > Isn't it better to just call clear_glyph_row explicitly?
>
> Hm...not sure, what about enabling enabled_p
You can do that by hand.
> and preserving reversed_p?
We don't support R2L toolbars anyway, there's a comment about that in
the code.
Anyway, if you prefer to do this your way, we should have a comment
there saying that disabling the row ensures prepare_desired_row will
clear it.
> And, of course, thanks for reviewing it.
You are welcome.
next prev parent reply other threads:[~2013-12-09 18:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 5:51 bug#16058: 24.3.50; X protocol error: BadAlloc Thierry Volpiatto
2013-12-05 6:51 ` Dmitry Antipov
2013-12-05 7:10 ` Thierry Volpiatto
2013-12-05 8:46 ` Dmitry Antipov
2013-12-05 17:44 ` Eli Zaretskii
2013-12-05 19:52 ` Jan Djärv
2013-12-06 6:26 ` Dmitry Antipov
2013-12-06 8:39 ` Thierry Volpiatto
2013-12-09 8:36 ` Dmitry Antipov
2013-12-09 16:43 ` Eli Zaretskii
2013-12-09 17:11 ` Dmitry Antipov
2013-12-09 18:15 ` Eli Zaretskii [this message]
2013-12-10 13:26 ` Dmitry Antipov
2013-12-14 8:13 ` Thierry Volpiatto
2013-12-14 8:56 ` Eli Zaretskii
2013-12-14 10:10 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834n6hzya5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=16058@debbugs.gnu.org \
--cc=dmantipov@yandex.ru \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.