From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Omitting Windows-specific parts from infrastructure changes Date: Sat, 17 Jan 2015 10:34:58 +0200 Message-ID: <834mrp24b1.fsf@gnu.org> References: <838uh32gpg.fsf@gnu.org> <54B9D960.1000001@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1421483733 30180 80.91.229.3 (17 Jan 2015 08:35:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 17 Jan 2015 08:35:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 17 09:35:32 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YCOqx-0004Lv-UX for ged-emacs-devel@m.gmane.org; Sat, 17 Jan 2015 09:35:32 +0100 Original-Received: from localhost ([::1]:58568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCOqw-00016C-WB for ged-emacs-devel@m.gmane.org; Sat, 17 Jan 2015 03:35:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCOqt-000167-6T for emacs-devel@gnu.org; Sat, 17 Jan 2015 03:35:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YCOqp-0000w4-Nr for emacs-devel@gnu.org; Sat, 17 Jan 2015 03:35:26 -0500 Original-Received: from mtaout27.012.net.il ([80.179.55.183]:38339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCOqp-0000vu-Fw for emacs-devel@gnu.org; Sat, 17 Jan 2015 03:35:23 -0500 Original-Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NIB00300B6X0Z00@mtaout27.012.net.il> for emacs-devel@gnu.org; Sat, 17 Jan 2015 10:27:17 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NIB00N0ZBHGBO60@mtaout27.012.net.il>; Sat, 17 Jan 2015 10:27:17 +0200 (IST) In-reply-to: <54B9D960.1000001@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.183 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181369 Archived-At: > Date: Fri, 16 Jan 2015 19:39:12 -0800 > From: Paul Eggert > > As a general rule any change that I make omits changes to MS-Windows > code. Sorry, that's not good enough. I'm sure when you do such changes, you grep (or otherwise search) the whole tree for relevant places, so you always know whether MS-Windows code is potentially involved. All I'm asking is that you provide that information when it is relevant. > I don't understand MS-Windows well enough to change its code > reliably, and I have no easy way to test any changes that I would > make. A change of strcpy/strcat to use stpcpy doesn't require any understanding of Windows specific code. A change in Makefile.in to use AM_V_* stuff doesn't require any Windows knowledge, either. I could give more examples, but I think these two are clear enough. Like I said: I'm okay with your refraining from making the changes, what I'm asking is to say that you spotted those places, with specific file names pointed out, but didn't make any changes there. Like I do when a display-related change needs changes in xterm.c or xfns.c or nsfns.m which I cannot test and sometimes cannot even compile.