all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: Omitting Windows-specific parts from infrastructure changes
Date: Sat, 17 Jan 2015 10:34:58 +0200	[thread overview]
Message-ID: <834mrp24b1.fsf@gnu.org> (raw)
In-Reply-To: <54B9D960.1000001@cs.ucla.edu>

> Date: Fri, 16 Jan 2015 19:39:12 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> 
> As a general rule any change that I make omits changes to MS-Windows
> code.

Sorry, that's not good enough.  I'm sure when you do such changes, you
grep (or otherwise search) the whole tree for relevant places, so you
always know whether MS-Windows code is potentially involved.  All I'm
asking is that you provide that information when it is relevant.

> I don't understand MS-Windows well enough to change its code
> reliably, and I have no easy way to test any changes that I would
> make.

A change of strcpy/strcat to use stpcpy doesn't require any
understanding of Windows specific code.  A change in Makefile.in to
use AM_V_* stuff doesn't require any Windows knowledge, either.  I
could give more examples, but I think these two are clear enough.

Like I said: I'm okay with your refraining from making the changes,
what I'm asking is to say that you spotted those places, with specific
file names pointed out, but didn't make any changes there.  Like I do
when a display-related change needs changes in xterm.c or xfns.c or
nsfns.m which I cannot test and sometimes cannot even compile.



  reply	other threads:[~2015-01-17  8:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16  9:54 Omitting Windows-specific parts from infrastructure changes Eli Zaretskii
2015-01-17  3:39 ` Paul Eggert
2015-01-17  8:34   ` Eli Zaretskii [this message]
2015-01-18 18:09     ` Paul Eggert
2015-01-18 18:23       ` Eli Zaretskii
2015-01-18 19:25         ` Paul Eggert
2015-01-18 19:50           ` Eli Zaretskii
2015-01-18 20:34             ` Paul Eggert
2015-01-19 16:03               ` Eli Zaretskii
2015-01-19 18:00                 ` Paul Eggert
2015-01-19 18:32                   ` Eli Zaretskii
2015-01-19 22:14                     ` Paul Eggert
2015-01-20 16:32                       ` Eli Zaretskii
2015-01-20 21:28                         ` Paul Eggert
2015-01-21 15:48                           ` Eli Zaretskii
2015-01-21 17:32                             ` Paul Eggert
2015-01-21 17:55                               ` Eli Zaretskii
2015-01-21 19:39                                 ` Paul Eggert
2015-01-21 20:07                                   ` Dmitry Gutov
2015-01-21 20:38                                     ` Eli Zaretskii
2015-01-21 20:08                                   ` David Kastrup
2015-01-21 20:49                                     ` Eli Zaretskii
2015-01-21 20:57                                       ` David Kastrup
2015-01-22  3:53                                         ` Eli Zaretskii
2015-01-21 20:30                                   ` Eli Zaretskii
2015-01-21 20:49                                     ` David Kastrup
2015-01-22  3:51                                       ` Eli Zaretskii
2015-01-22 14:20                                         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834mrp24b1.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.