From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20498: 25.0.50; PATCH: break potential infinite loop in (line-move-to-column) Date: Mon, 04 May 2015 17:27:43 +0300 Message-ID: <834mnsto2o.fsf@gnu.org> References: <87k2wp8nji.fsf@secretsauce.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1430749764 13476 80.91.229.3 (4 May 2015 14:29:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 May 2015 14:29:24 +0000 (UTC) Cc: 20498@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 04 16:29:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YpHMv-0005rY-8Q for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 May 2015 16:29:13 +0200 Original-Received: from localhost ([::1]:34443 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpHMu-0003M2-Hp for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 May 2015 10:29:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpHMo-0003Lv-6Y for bug-gnu-emacs@gnu.org; Mon, 04 May 2015 10:29:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpHMk-0004gg-Re for bug-gnu-emacs@gnu.org; Mon, 04 May 2015 10:29:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpHMk-0004gc-PH for bug-gnu-emacs@gnu.org; Mon, 04 May 2015 10:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YpHMk-0000ah-GJ for bug-gnu-emacs@gnu.org; Mon, 04 May 2015 10:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 May 2015 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20498 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20498-submit@debbugs.gnu.org id=B20498.14307497082207 (code B ref 20498); Mon, 04 May 2015 14:29:02 +0000 Original-Received: (at 20498) by debbugs.gnu.org; 4 May 2015 14:28:28 +0000 Original-Received: from localhost ([127.0.0.1]:33796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YpHMC-0000ZW-3N for submit@debbugs.gnu.org; Mon, 04 May 2015 10:28:28 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:64276) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YpHM9-0000ZI-JS for 20498@debbugs.gnu.org; Mon, 04 May 2015 10:28:26 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NNT00K00XD4RQ00@a-mtaout22.012.net.il> for 20498@debbugs.gnu.org; Mon, 04 May 2015 17:27:43 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NNT00KROXI4RN00@a-mtaout22.012.net.il>; Mon, 04 May 2015 17:27:40 +0300 (IDT) In-reply-to: <87k2wp8nji.fsf@secretsauce.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102445 Archived-At: > From: Dima Kogan > Date: Sun, 03 May 2015 12:32:33 -0700 > > (line-move-to-column) has a loop that can become infinite: > > (while (and ...) > (goto-char (previous-char-property-change (point) line-beg))) > > If (= (point) line-beg) then the (goto-char) does nothing, and the > condition in the while never changes. The full fragment is this: (let ((line-beg (line-beginning-position))) (while (and (not (bolp)) (invisible-p (1- (point)))) (goto-char (previous-char-property-change (point) line-beg)))))))) So if (= (point) line-beg), then 'bolp' will return t, and we will break from the loop. Am I missing something? > I'm seeing this in the wild with ERC and erc-fill-mode disabled. Can you dig deeper into the problem, and tell the details about this infloop?