From: Eli Zaretskii <eliz@gnu.org>
To: Dima Kogan <dima@secretsauce.net>
Cc: 20498@debbugs.gnu.org
Subject: bug#20498: 25.0.50; PATCH: break potential infinite loop in (line-move-to-column)
Date: Mon, 04 May 2015 17:27:43 +0300 [thread overview]
Message-ID: <834mnsto2o.fsf@gnu.org> (raw)
In-Reply-To: <87k2wp8nji.fsf@secretsauce.net>
> From: Dima Kogan <dima@secretsauce.net>
> Date: Sun, 03 May 2015 12:32:33 -0700
>
> (line-move-to-column) has a loop that can become infinite:
>
> (while (and ...)
> (goto-char (previous-char-property-change (point) line-beg)))
>
> If (= (point) line-beg) then the (goto-char) does nothing, and the
> condition in the while never changes.
The full fragment is this:
(let ((line-beg (line-beginning-position)))
(while (and (not (bolp)) (invisible-p (1- (point))))
(goto-char (previous-char-property-change (point) line-beg))))))))
So if (= (point) line-beg), then 'bolp' will return t, and we will
break from the loop. Am I missing something?
> I'm seeing this in the wild with ERC and erc-fill-mode disabled.
Can you dig deeper into the problem, and tell the details about this
infloop?
next prev parent reply other threads:[~2015-05-04 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 19:32 bug#20498: 25.0.50; PATCH: break potential infinite loop in (line-move-to-column) Dima Kogan
2015-05-04 14:27 ` Eli Zaretskii [this message]
2015-05-05 8:29 ` Dima Kogan
2015-05-09 13:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834mnsto2o.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=20498@debbugs.gnu.org \
--cc=dima@secretsauce.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.