From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11822: 24.1; emacsclient terminal mode captures escape characters as text Date: Tue, 15 Sep 2015 17:29:33 +0300 Message-ID: <834miv92nm.fsf@gnu.org> References: <6eipe9fypj.fsf@just-testing.permabit.com> <501848BE.10702@permabit.com> <5021D940.8050401@permabit.com> <415962DC-9BF5-4595-8180-7BE8DB545206@permabit.com> <502427D2.3080003@permabit.com> <83ipcre0fm.fsf@gnu.org> <2AB38709-2307-437E-A242-70B8A358BE4F@permabit.com> <83a9y3dwa8.fsf@gnu.org> <838vdndv9m.fsf@gnu.org> <1341183F-84AB-4257-B28B-57BDE5CA4F20@permabit.com> <83r3m97bzs.fsf@gnu.org> <37C523EE-3D76-40F7-B7B2-99D6F0BD7B97@permabit.com> <83bndc7r5b.fsf@gnu.org> <6ea8swr8ja.fsf@just-testing.permabit.com> <83si6n65ld.fsf@gnu.org> <6e613irc91.fsf@just-testing.permabit.com> <83bnda5lso.fsf@gnu.org> <6ezj0tphtd.fsf@just-testing.permabit.com> <83h9n14e04.fsf@gnu.org> <6esi6kpn4t.fsf@just-testing.permabit.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1442327441 30155 80.91.229.3 (15 Sep 2015 14:30:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Sep 2015 14:30:41 +0000 (UTC) Cc: raeburn@permabit.com, 11822@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 15 16:30:29 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZbrFa-0007zr-52 for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Sep 2015 16:30:26 +0200 Original-Received: from localhost ([::1]:43335 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbrFZ-0007lI-Hc for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Sep 2015 10:30:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbrFK-0007S2-7A for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2015 10:30:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbrFE-0007XA-H0 for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2015 10:30:10 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbrFE-0007WT-Ex for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2015 10:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZbrFD-0007vg-SN for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2015 10:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Sep 2015 14:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11822 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11822-submit@debbugs.gnu.org id=B11822.144232737630407 (code B ref 11822); Tue, 15 Sep 2015 14:30:03 +0000 Original-Received: (at 11822) by debbugs.gnu.org; 15 Sep 2015 14:29:36 +0000 Original-Received: from localhost ([127.0.0.1]:33359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbrEm-0007uN-40 for submit@debbugs.gnu.org; Tue, 15 Sep 2015 10:29:36 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:44156) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZbrEj-0007u9-Id for 11822@debbugs.gnu.org; Tue, 15 Sep 2015 10:29:34 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NUQ00C002F4V500@mtaout25.012.net.il> for 11822@debbugs.gnu.org; Tue, 15 Sep 2015 17:26:25 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NUQ004LK2S11OA0@mtaout25.012.net.il>; Tue, 15 Sep 2015 17:26:25 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106592 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii , 11822@debbugs.gnu.org > Date: Fri, 11 Sep 2015 20:51:46 -0400 > > > (Also: Iconifying the remote frame doesn't seem to help. In > > prepare_menu_bars, when all_windows is set but some_windows is not, the > > call to x_consider_frame_title, which can trigger face realization, *is* > > called for iconified frames.) > > Maybe instead of doing > > prepare_menu_bars: > (forall frames (compute-title-and-stuff)) > later: > (forall frames (recompute-glyph-matrices-and-then-display)) > > we should do > > (forall frames > (compute-title-and-stuff) > (recompute-glyph-matrices-and-then-display)) But what we do now is not exactly what's outlined above. Instead, it's something like prepare_menu_bars: if (windows_or_buffers_changed) (forall frames (compute-title-and-stuff)) later: if (windows_or_buffers_changed) (forall frames (recompute-glyph-matrices-and-then-display)) else (for selected-frame (recompute-glyph-matrices-and-then-display)) So the problematic calls to face realization are once again triggered by the face_change flag, which in turns assigns a non-zero value to windows_or_buffers_changed, which then causes the loop in prepare_menu_bars. IOW, making face_change a frame-local flag should solve this issue as well.