From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Use of strftime in movemail.ec Date: Sun, 06 Mar 2016 18:28:52 +0200 Message-ID: <834mcjwoxn.fsf@gnu.org> References: <83h9glxk60.fsf@gnu.org> <56DB35DB.90005@cs.ucla.edu> <83r3fowvb1.fsf@gnu.org> <83pov8wtib.fsf@gnu.org> <56DB4811.9060306@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1457281757 7762 80.91.229.3 (6 Mar 2016 16:29:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Mar 2016 16:29:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 06 17:29:10 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1acbYK-0000NO-6L for ged-emacs-devel@m.gmane.org; Sun, 06 Mar 2016 17:29:08 +0100 Original-Received: from localhost ([::1]:51104 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acbYJ-0001Q3-MP for ged-emacs-devel@m.gmane.org; Sun, 06 Mar 2016 11:29:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acbY6-0001PY-3L for emacs-devel@gnu.org; Sun, 06 Mar 2016 11:28:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acbY1-0001iu-Kb for emacs-devel@gnu.org; Sun, 06 Mar 2016 11:28:54 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acbY1-0001iq-HX; Sun, 06 Mar 2016 11:28:49 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3286 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1acbY0-0000cy-LE; Sun, 06 Mar 2016 11:28:49 -0500 In-reply-to: <56DB4811.9060306@cs.ucla.edu> (message from Paul Eggert on Sat, 5 Mar 2016 12:56:49 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200998 Archived-At: > Cc: emacs-devel@gnu.org > From: Paul Eggert > Date: Sat, 5 Mar 2016 12:56:49 -0800 > > Eli Zaretskii wrote: > > How about the follow-up below? > > Yes, that's more general and shouldn't introduce bugs. It can mishandle %% in > formats, if you care about full upward-compatibility. It should use memcpy > instead of strncpy. > > Personally I'd leave the code alone for simplicity's sake, but if you prefer the > more-general version by all means.... Thanks for the review and the comments. I fixed the patch as you suggested and pushed it.