bug#19559: 24.3; C-n in doc-view-mode

bug#19559: 24.3; C-n in doc-view-mode

[Robert Thorpe]

I start Emacs and view a pdf file using doc-view.  The pdf looks fine,
it's a pdf where each page is bigger than the Emacs frame in both x and
y.  I use C-n, C-p, C-f & C-b to move around.  If I use a prefix
argument that works for C-p, C-f & C-b.  So, if I press C-f the pdf
moves one unit, and if I type C-9 C-f it moves 9 units.  But, C-n
doesn't work properly.  If I press C-n it moves one unit down, and if I
press C-9 C-n it also moves *one* unit down.  This happens for any type
of prefix argument (C-u, C-u 6, M-5, etc).  It happens on Emacs 24.3 on
Xubuntu and on Emacs 24.4 on MS Windows.  In both cases it happens with
and without my init file (emacs -q).



In GNU Emacs 24.3.1 (i686-pc-linux-gnu, GTK+ Version 3.4.2)
 of 2014-02-22 on chindi10, modified by Debian
Windowing system distributor `The X.Org Foundation', version 11.0.11103000
System Description:	Ubuntu 12.04.5 LTS

Configured using:
 `configure '--build' 'i686-linux-gnu' '--build' 'i686-linux-gnu'
 '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib'
 '--localstatedir=/var/lib' '--infodir=/usr/share/info'
 '--mandir=/usr/share/man' '--with-pop=yes'
 '--enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.3/site-lisp:/usr/share/emacs/site-lisp'
 '--with-crt-dir=/usr/lib/i386-linux-gnu' '--with-x=yes'
 '--with-x-toolkit=gtk3' '--with-toolkit-scroll-bars'
 'build_alias=i686-linux-gnu' 'CFLAGS=-g -O2 -fstack-protector
 --param=ssp-buffer-size=4 -Wformat -Wformat-security
 -Werror=format-security -Wall' 'LDFLAGS=-Wl,-Bsymbolic-functions
 -Wl,-z,relro' 'CPPFLAGS=-D_FORTIFY_SOURCE=2''

Important settings:
  value of $LC_MONETARY: en_GB.UTF-8
  value of $LC_NUMERIC: en_GB.UTF-8
  value of $LC_TIME: en_GB.UTF-8
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Text

Minor modes in effect:
  dynamic-completion-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  global-visual-line-mode: t
  visual-line-mode: t
  transient-mark-mode: t

Recent input:
M-x r e p <tab> o <tab> r <tab> <return>

Recent messages:
Loading debian-ispell...
Loading /var/cache/dictionaries-common/emacsen-ispell-default.el (source)...done
Loading debian-ispell...done
Loading /var/cache/dictionaries-common/emacsen-ispell-dicts.el (source)...done
Loading /etc/emacs/site-start.d/50dictionaries-common.el (source)...done
Loading completions from file /home/rt/.emacs.d/completions . . .
Loading completions from file /home/rt/.emacs.d/completions . . . Done.
Loading /home/rt/my_rmail_insert_inbox_text.el (source)...done
For information about GNU Emacs and the GNU system, type C-h C-a.
Making completion list... [2 times]

Load-path shadows:
/usr/share/emacs/24.3/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup
/usr/share/emacs24/site-lisp/dictionaries-common/flyspell hides /usr/share/emacs/24.3/lisp/textmodes/flyspell
/usr/share/emacs24/site-lisp/dictionaries-common/ispell hides /usr/share/emacs/24.3/lisp/textmodes/ispell

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail help-mode easymenu rmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils uniquify advice help-fns cl-lib
advice-preload edmacro kmacro server completion ido avoid time-date
tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
register page menu-bar rfn-eshadow timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer loaddefs button faces cus-face macroexp files text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty emacs)

bug#19559: 24.3; C-n in doc-view-mode

[Marcin Borkowski]

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

Hello,

I attach a patch prepared using git-format-patch.  It's my first patch
for Emacs, so please let me know if I did it correctly (especially wrt
the commit message).

Best,

-- 
Marcin


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-bug-19559.patch --]
[-- Type: text/x-patch, Size: 868 bytes --]

From 0f616d9501a5bd56381a4e8198816d2f26b6ae9e Mon Sep 17 00:00:00 2001
From: Marcin Borkowski <mbork@mbork.pl>
Date: Mon, 14 Mar 2016 11:15:10 +0100
Subject: [PATCH] Fix bug #19559

The function `doc-view-next-line-or-next-page' disregarded its argument
when continuous scrolling was not in effect (i.e., by default).
---
 lisp/doc-view.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index 9d912c3..223565c 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -626,7 +626,7 @@ doc-view-next-line-or-next-page
 	    (image-bob)
 	    (image-bol 1))
 	  (set-window-hscroll (selected-window) hscroll)))
-    (image-next-line 1)))
+    (image-next-line arg)))
 
 (defun doc-view-previous-line-or-previous-page (&optional arg)
   "Scroll downward by ARG lines if possible, else goto previous page.
-- 
2.4.3

bug#19559: 24.3; C-n in doc-view-mode

[Eli Zaretskii]

> From: Marcin Borkowski <mbork@mbork.pl>
> Date: Mon, 14 Mar 2016 11:20:48 +0100
> Cc: 19559@debbugs.gnu.org
> 
> I attach a patch prepared using git-format-patch.  It's my first patch
> for Emacs, so please let me know if I did it correctly (especially wrt
> the commit message).

Looks good to me, but please prepare the commit message in the
ChangeLog format.  "C-x 4 a" with point inside the function you
changed is a good start.

Thanks.

bug#19559: 24.3; C-n in doc-view-mode

[Robert Thorpe]

Marcin Borkowski <mbork@mbork.pl> writes:

> Hello,
>
> I attach a patch prepared using git-format-patch.  It's my first patch
> for Emacs, so please let me know if I did it correctly (especially wrt
> the commit message).

It's fine as far as I can see.

Thanks for fixing it,

Rob

bug#19559: 24.3; C-n in doc-view-mode

[Marcin Borkowski]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]


On 2016-03-14, at 17:20, Eli Zaretskii <eliz@gnu.org> wrote:

>> From: Marcin Borkowski <mbork@mbork.pl>
>> Date: Mon, 14 Mar 2016 11:20:48 +0100
>> Cc: 19559@debbugs.gnu.org
>> 
>> I attach a patch prepared using git-format-patch.  It's my first patch
>> for Emacs, so please let me know if I did it correctly (especially wrt
>> the commit message).
>
> Looks good to me, but please prepare the commit message in the
> ChangeLog format.  "C-x 4 a" with point inside the function you
> changed is a good start.

Is it better now?

> Thanks.

Best,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-bug-19559.patch --]
[-- Type: text/x-patch, Size: 944 bytes --]

From e31779e8c88aa1b83a90af386b0049d1f65ce6a2 Mon Sep 17 00:00:00 2001
From: Marcin Borkowski <mbork@mbork.pl>
Date: Mon, 14 Mar 2016 11:15:10 +0100
Subject: [PATCH] Fix bug #19559

2016-03-16  Marcin Borkowski  <mbork@mbork.pl>

	* lisp/doc-view.el (doc-view-next-line-or-next-page): Take the
	prefix argument into consideration when continuous scrolling is
	not in effect (i.e., by default).
---
 lisp/doc-view.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index 9d912c3..223565c 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -626,7 +626,7 @@ doc-view-next-line-or-next-page
 	    (image-bob)
 	    (image-bol 1))
 	  (set-window-hscroll (selected-window) hscroll)))
-    (image-next-line 1)))
+    (image-next-line arg)))
 
 (defun doc-view-previous-line-or-previous-page (&optional arg)
   "Scroll downward by ARG lines if possible, else goto previous page.
-- 
2.4.3

bug#19559: 24.3; C-n in doc-view-mode

[Eli Zaretskii]

> From: Marcin Borkowski <mbork@mbork.pl>
> Cc: rt@robertthorpeconsulting.com, 19559@debbugs.gnu.org
> Date: Wed, 16 Mar 2016 19:30:09 +0100
> 
> > Looks good to me, but please prepare the commit message in the
> > ChangeLog format.  "C-x 4 a" with point inside the function you
> > changed is a good start.
> 
> Is it better now?

Yes, thanks.

bug#19559: 24.3; C-n in doc-view-mode

[Tassilo Horn]

Marcin Borkowski <mbork@mbork.pl> writes:

Hi Marcin,

>> Looks good to me, but please prepare the commit message in the
>> ChangeLog format.  "C-x 4 a" with point inside the function you
>> changed is a good start.
>
> Is it better now?

As Eli said: yes, now it's fine.  Do you have push access or should I do
that for you?

Bye,
Tassilo

bug#19559: 24.3; C-n in doc-view-mode

[Marcin Borkowski]

On 2016-03-18, at 22:08, Tassilo Horn <tsdh@gnu.org> wrote:

> Marcin Borkowski <mbork@mbork.pl> writes:
>
> Hi Marcin,
>
>>> Looks good to me, but please prepare the commit message in the
>>> ChangeLog format.  "C-x 4 a" with point inside the function you
>>> changed is a good start.
>>
>> Is it better now?
>
> As Eli said: yes, now it's fine.  Do you have push access or should I do
> that for you?

Good to hear that.  No, I don't have push access (yet).

> Bye,
> Tassilo

Best,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University

bug#19559: 24.3; C-n in doc-view-mode

[Tassilo Horn]

Marcin Borkowski <mbork@mbork.pl> writes:

Hi Marcin,

>>> Is it better now?
>>
>> As Eli said: yes, now it's fine.  Do you have push access or should I
>> do that for you?
>
> Good to hear that.  No, I don't have push access (yet).

Ok, pushed.  And thereby I saw that the commit message wasn't completely
correct.  It should not contain the ChangeLog header (Date + Name +
Email) because that's already present in the commit itself and will be
generated from that by the ChangeLog generation script.  And I gave it a
more obvious summary line.

Anyway, thanks a lot for the patch!

Bye,
Tassilo