From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23144: shrinking windows with gtk 3.20 Date: Sat, 02 Apr 2016 19:28:23 +0300 Message-ID: <834mbkrn4o.fsf@gnu.org> References: <56FF0C5B.1020201@cs.ucla.edu> <83r3eosdde.fsf@gnu.org> <8360w0rp10.fsf@gnu.org> <56FFEDF8.5030704@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1459614621 15070 80.91.229.3 (2 Apr 2016 16:30:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Apr 2016 16:30:21 +0000 (UTC) Cc: 23144@debbugs.gnu.org, eggert@cs.ucla.edu, matthias.clasen@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 02 18:30:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1amOR7-0004rs-5p for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Apr 2016 18:30:09 +0200 Original-Received: from localhost ([::1]:50221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amOR6-0003pW-H9 for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Apr 2016 12:30:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amOR3-0003oC-OG for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 12:30:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amOR0-0004I8-Fd for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 12:30:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amOR0-0004I2-Cv for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 12:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1amOR0-0003Ft-5F for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 12:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Apr 2016 16:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23144 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23144-submit@debbugs.gnu.org id=B23144.145961454512423 (code B ref 23144); Sat, 02 Apr 2016 16:30:02 +0000 Original-Received: (at 23144) by debbugs.gnu.org; 2 Apr 2016 16:29:05 +0000 Original-Received: from localhost ([127.0.0.1]:49036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amOQ5-0003EJ-KA for submit@debbugs.gnu.org; Sat, 02 Apr 2016 12:29:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amOQ4-0003Dq-5s for 23144@debbugs.gnu.org; Sat, 02 Apr 2016 12:29:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amOPy-00042P-6d for 23144@debbugs.gnu.org; Sat, 02 Apr 2016 12:28:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amOPu-00041u-5o; Sat, 02 Apr 2016 12:28:54 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1268 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1amOPt-0008E4-C2; Sat, 02 Apr 2016 12:28:53 -0400 In-reply-to: <56FFEDF8.5030704@gmx.at> (message from martin rudalics on Sat, 02 Apr 2016 18:06:16 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115876 Archived-At: > Date: Sat, 02 Apr 2016 18:06:16 +0200 > From: martin rudalics > CC: 23144@debbugs.gnu.org, eggert@cs.ucla.edu > > In emacs-25 either use something like > > #if !GTK_CHECK_VERSION (3, 20, 0)) > xg_frame_resized (f, -1, -1); > #endif I hope we do that on master. If not, we should. There's no reason not to continue calling xg_frame_resized with older versions of GTK, as it works there. I'm wary of doing this in Emacs 25.1. > or, as Matthias proposed, in xg_frame_resized write > > if (pixelwidth == -1 && pixelheight == -1) > { > if (FRAME_GTK_WIDGET (f) && gtk_widget_get_mapped (FRAME_GTK_WIDGET (f))) > { > gdk_window_get_geometry (gtk_widget_get_window (FRAME_GTK_WIDGET (f)), > 0, 0, &pixelwidth, &pixelheight); > if (pixelwidth <= 1 || pixelheight <= 1) > return; > } > else > return; > } Do we understand the effect of this? It effectively makes the xg_frame_resized call a no-op, but I very much doubt that this call was added there with no good reason. Does the history of this addition, including any related discussions, teach us something about the reason? Thanks.