From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 23144@debbugs.gnu.org, eggert@cs.ucla.edu, matthias.clasen@gmail.com
Subject: bug#23144: shrinking windows with gtk 3.20
Date: Sat, 02 Apr 2016 19:28:23 +0300 [thread overview]
Message-ID: <834mbkrn4o.fsf@gnu.org> (raw)
In-Reply-To: <56FFEDF8.5030704@gmx.at> (message from martin rudalics on Sat, 02 Apr 2016 18:06:16 +0200)
> Date: Sat, 02 Apr 2016 18:06:16 +0200
> From: martin rudalics <rudalics@gmx.at>
> CC: 23144@debbugs.gnu.org, eggert@cs.ucla.edu
>
> In emacs-25 either use something like
>
> #if !GTK_CHECK_VERSION (3, 20, 0))
> xg_frame_resized (f, -1, -1);
> #endif
I hope we do that on master. If not, we should. There's no reason
not to continue calling xg_frame_resized with older versions of GTK,
as it works there.
I'm wary of doing this in Emacs 25.1.
> or, as Matthias proposed, in xg_frame_resized write
>
> if (pixelwidth == -1 && pixelheight == -1)
> {
> if (FRAME_GTK_WIDGET (f) && gtk_widget_get_mapped (FRAME_GTK_WIDGET (f)))
> {
> gdk_window_get_geometry (gtk_widget_get_window (FRAME_GTK_WIDGET (f)),
> 0, 0, &pixelwidth, &pixelheight);
> if (pixelwidth <= 1 || pixelheight <= 1)
> return;
> }
> else
> return;
> }
Do we understand the effect of this? It effectively makes the
xg_frame_resized call a no-op, but I very much doubt that this call
was added there with no good reason. Does the history of this
addition, including any related discussions, teach us something about
the reason?
Thanks.
next prev parent reply other threads:[~2016-04-02 16:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 20:52 bug#23144: shrinking windows with gtk 3.20 Matthias Clasen
2016-03-29 15:18 ` martin rudalics
2016-03-29 16:02 ` Eli Zaretskii
2016-03-29 17:20 ` martin rudalics
2016-03-31 16:09 ` John Wiegley
2016-04-01 7:48 ` martin rudalics
2016-04-01 9:46 ` Eli Zaretskii
2016-04-02 0:03 ` Paul Eggert
2016-04-02 7:01 ` Eli Zaretskii
2016-04-02 15:19 ` Matthias Clasen
2016-04-02 15:47 ` Eli Zaretskii
2016-04-02 16:06 ` martin rudalics
2016-04-02 16:28 ` Eli Zaretskii [this message]
2016-04-02 17:27 ` Matthias Clasen
2016-04-02 17:32 ` Eli Zaretskii
2016-04-02 23:20 ` Matthias Clasen
2016-04-03 2:36 ` Eli Zaretskii
2016-05-16 6:53 ` Paul Eggert
2016-05-16 8:21 ` martin rudalics
2016-05-16 15:53 ` Eli Zaretskii
2016-05-16 17:11 ` Paul Eggert
2017-03-24 13:01 ` Ken Brown
2017-03-24 13:24 ` martin rudalics
2017-03-24 13:38 ` Ken Brown
2017-03-24 18:52 ` martin rudalics
2017-03-24 13:35 ` Eli Zaretskii
2017-03-24 14:08 ` Ken Brown
2017-03-24 14:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834mbkrn4o.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23144@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=matthias.clasen@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.