From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v5] Add systemd socket launching support Date: Sat, 16 Apr 2016 12:50:27 +0300 Message-ID: <834mb1dgrg.fsf@gnu.org> References: <871t6do8w1.fsf@mattleach.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1460800256 24968 80.91.229.3 (16 Apr 2016 09:50:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Apr 2016 09:50:56 +0000 (UTC) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Matthew Leach Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 16 11:50:56 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1arMsR-0002mq-OY for ged-emacs-devel@m.gmane.org; Sat, 16 Apr 2016 11:50:55 +0200 Original-Received: from localhost ([::1]:52450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arMsR-0007Xr-Cu for ged-emacs-devel@m.gmane.org; Sat, 16 Apr 2016 05:50:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arMsN-0007VG-RB for emacs-devel@gnu.org; Sat, 16 Apr 2016 05:50:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1arMsM-0005vN-Sf for emacs-devel@gnu.org; Sat, 16 Apr 2016 05:50:51 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1arMsJ-0005vB-2I; Sat, 16 Apr 2016 05:50:47 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2984 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1arMsI-0008Hz-AX; Sat, 16 Apr 2016 05:50:46 -0400 In-reply-to: <871t6do8w1.fsf@mattleach.net> (message from Matthew Leach on Sun, 10 Apr 2016 15:06:54 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:202986 Archived-At: > From: Matthew Leach > Cc: Eli Zaretskii , Stefan Monnier > Date: Sun, 10 Apr 2016 15:06:54 +0100 > > Here is a new version of the systemd integration & socket-launching > patches. The main change in this series is providing an interface for > other socket-launching applications to be integrated, namely > `set_external_socket_descriptor' in process.c. > > Feedback & comments welcome! Thanks, I pushed it to the master branch. I think it would make sense to add this feature to the list in EMACS_CONFIG_FEATURES (see the configure script for how we generate that list). A few minor comments, for the future: . Be consistent in how you quote symbols in the log entries. In this submission, you sometimes quoted `like this', sometimes 'like this', and sometimes left the symbols unquoted. Pick one style and stick to it. . The way to call out a function name is 'function' (with quotes). The GNU Coding Standards frown upon using function(), which looks like a call to the function with no arguments, not what you mean. Thanks again for working on this.