From: Eli Zaretskii <eliz@gnu.org>
To: phillip.lord@russet.org.uk (Phillip Lord)
Cc: 23871@debbugs.gnu.org, triska@metalevel.at
Subject: bug#23871: 25.1.50; Undo unexpectedly leads to blank buffer
Date: Sun, 03 Jul 2016 06:31:18 +0300 [thread overview]
Message-ID: <834m87s8hl.fsf@gnu.org> (raw)
In-Reply-To: <87k2h37pvb.fsf@russet.org.uk> (phillip.lord@russet.org.uk)
> From: phillip.lord@russet.org.uk (Phillip Lord)
> Cc: triska@metalevel.at, 23871@debbugs.gnu.org
> Date: Sat, 02 Jul 2016 21:21:28 +0100
>
> > The problem, AFAIU, is in point movements _during_ eval-defun: they
> > seem to not be recorded in buffer-undo-list. The undo list I get
> > after C-M-x is this:
> >
> > (nil (117 . 122) (t 22391 27551 0 0))
> >
>
> So, I don't think this is a regression caused by my patch at all. It is
> an bug that has been there since I altered undo.c last year.
>
> The problem was caused because of undo only records point after a
> boundary (or the first element). I'd changed things during slightly when
> I update undo.c so that the timestamp list got added before checking
> whether I was at a boundary, hence blocking addition of the point
> restoration information.
>
> This is why I found the problem so erratic to replicate; it only occurs
> immediately the first change to a buffer.
>
> I believe the following patch addresses the issue.
Seems like this is still not the final patch, so I guess we will need
to wait for the right one. It should go to the emacs-25 branch, which
probably means one more pretest, sigh.
Thanks.
next prev parent reply other threads:[~2016-07-03 3:31 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 21:47 bug#23871: 25.1.50; Undo unexpectedly leads to blank buffer Markus Triska
2016-06-30 16:38 ` Eli Zaretskii
2016-06-30 18:00 ` Markus Triska
2016-06-30 18:21 ` Eli Zaretskii
2016-06-30 18:52 ` Eli Zaretskii
2016-06-30 21:45 ` Phillip Lord
2016-07-01 6:31 ` Markus Triska
2016-07-01 7:25 ` Eli Zaretskii
2016-07-01 14:04 ` Phillip Lord
2016-07-01 20:38 ` Markus Triska
2016-07-01 22:12 ` Phillip Lord
2016-07-01 20:49 ` Markus Triska
2016-07-01 22:21 ` Phillip Lord
2016-07-02 5:35 ` Markus Triska
2016-07-02 7:35 ` Eli Zaretskii
2016-07-02 20:21 ` Phillip Lord
2016-07-02 20:53 ` Markus Triska
2016-07-03 3:33 ` Eli Zaretskii
2016-07-03 9:37 ` Phillip Lord
2016-07-03 10:08 ` Markus Triska
2016-07-03 12:55 ` Phillip Lord
2016-07-03 15:30 ` Eli Zaretskii
2016-07-03 20:21 ` Phillip Lord
2016-07-03 18:05 ` Markus Triska
2016-07-03 20:23 ` Phillip Lord
2016-07-03 22:03 ` Markus Triska
2016-07-04 14:38 ` Eli Zaretskii
2016-07-05 16:36 ` Eli Zaretskii
2016-07-05 19:44 ` Phillip Lord
2016-07-05 20:02 ` Markus Triska
2016-07-05 19:47 ` Markus Triska
2016-07-05 20:00 ` Eli Zaretskii
2016-07-03 15:12 ` Eli Zaretskii
2016-07-03 18:09 ` Markus Triska
2016-07-03 19:20 ` Eli Zaretskii
2016-07-03 20:37 ` Phillip Lord
2016-07-03 3:31 ` Eli Zaretskii [this message]
2016-07-03 9:39 ` Phillip Lord
2016-07-03 21:33 ` Stefan Monnier
2016-07-04 20:34 ` Phillip Lord
2016-07-04 21:32 ` Stefan Monnier
2016-07-05 8:43 ` Phillip Lord
2016-07-05 20:32 ` Markus Triska
2016-07-05 22:00 ` Stefan Monnier
2016-07-05 22:17 ` Phillip Lord
2016-07-05 22:09 ` Phillip Lord
2016-07-05 23:03 ` Markus Triska
2016-07-06 16:02 ` Phillip Lord
2016-07-06 17:59 ` Markus Triska
2016-08-12 23:03 ` npostavs
2016-08-13 8:02 ` Markus Triska
2016-07-05 8:46 ` undo refactoring Phillip Lord
2016-07-05 21:50 ` Stefan Monnier
2016-07-05 22:22 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834m87s8hl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23871@debbugs.gnu.org \
--cc=phillip.lord@russet.org.uk \
--cc=triska@metalevel.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.