From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: 23386@debbugs.gnu.org, npostavs@users.sourceforge.net
Subject: bug#23386: Segfault when messing with font-backend
Date: Tue, 12 Jul 2016 20:45:30 +0300 [thread overview]
Message-ID: <834m7ubvid.fsf@gnu.org> (raw)
In-Reply-To: <86d31541-774c-3605-41b7-2aae0efd7abb@yandex.ru> (message from Dmitry Antipov on Tue, 12 Jul 2016 18:20:41 +0300)
> Cc: 23386@debbugs.gnu.org
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Date: Tue, 12 Jul 2016 18:20:41 +0300
>
> > But it doesn't do what the user asked for.
> >
> > I don't see why it would be meaningless to evict a backend and start
> > using another one, if all it takes is re-open a bunch of fonts.
>
> OK, the following patch basically works for me (not tested too much, BTW).
Thanks.
> --- a/src/frame.c
> +++ b/src/frame.c
> @@ -3712,7 +3712,11 @@ x_set_font_backend (struct frame *f, Lisp_Object new_value, Lisp_Object old_valu
> return;
>
> if (FRAME_FONT (f))
> - free_all_realized_faces (Qnil);
> + {
> + Lisp_Object frame;
> + XSETFRAME (frame, f);
> + free_all_realized_faces (frame);
> + }
Since free_all_realized_faces with a nil argument will free faces on
all frames, can you tell why this hunk was needed?
next prev parent reply other threads:[~2016-07-12 17:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 13:13 bug#23386: Segfault when messing with font-backend Stefan Monnier
2016-04-27 14:02 ` Eli Zaretskii
2016-04-27 14:23 ` Stefan Monnier
2016-07-09 19:11 ` npostavs
2016-07-09 20:02 ` npostavs
2016-07-10 14:18 ` Eli Zaretskii
2016-07-10 20:15 ` npostavs
2016-07-10 17:29 ` Dmitry Antipov
2016-07-10 20:17 ` npostavs
2016-07-11 14:33 ` Eli Zaretskii
2016-07-12 15:20 ` Dmitry Antipov
2016-07-12 17:45 ` Eli Zaretskii [this message]
2016-07-12 17:58 ` Dmitry Antipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834m7ubvid.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23386@debbugs.gnu.org \
--cc=dmantipov@yandex.ru \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.