From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Date: Sat, 23 Jul 2016 11:54:47 +0300 Message-ID: <834m7gwx7s.fsf@gnu.org> References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> <83inw2227y.fsf@gnu.org> <87r3aqbppk.fsf@web.de> <83d1ma1hai.fsf@gnu.org> <87a8hbdcfd.fsf@users.sourceforge.net> <83d1m7yssc.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1469264837 10281 80.91.229.3 (23 Jul 2016 09:07:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Jul 2016 09:07:17 +0000 (UTC) Cc: michael_heerdegen@web.de, 23648@debbugs.gnu.org, pogonyshev@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 23 11:07:06 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQstl-0003Xf-DV for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Jul 2016 11:07:05 +0200 Original-Received: from localhost ([::1]:51051 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQstk-00049Y-Gm for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Jul 2016 05:07:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQsiA-0002hM-OB for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2016 04:55:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQsi6-0000Sp-IE for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2016 04:55:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50084) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQsi6-0000Sk-EN for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2016 04:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bQsi6-0001CC-5r for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2016 04:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jul 2016 08:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.14692640894574 (code B ref 23648); Sat, 23 Jul 2016 08:55:02 +0000 Original-Received: (at 23648) by debbugs.gnu.org; 23 Jul 2016 08:54:49 +0000 Original-Received: from localhost ([127.0.0.1]:34188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQsht-0001Bh-Ki for submit@debbugs.gnu.org; Sat, 23 Jul 2016 04:54:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQshs-0001BW-EJ for 23648@debbugs.gnu.org; Sat, 23 Jul 2016 04:54:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQshm-0000NK-DF for 23648@debbugs.gnu.org; Sat, 23 Jul 2016 04:54:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQshi-0000MJ-K3; Sat, 23 Jul 2016 04:54:38 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2443 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bQshg-000726-Gc; Sat, 23 Jul 2016 04:54:37 -0400 In-reply-to: (message from Noam Postavsky on Thu, 21 Jul 2016 17:27:49 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121444 Archived-At: > From: Noam Postavsky > Date: Thu, 21 Jul 2016 17:27:49 -0400 > Cc: Michael Heerdegen , 23648@debbugs.gnu.org, > Paul Pogonyshev > > > So I'm still looking for the answer to the "how probable" question. I > > need that to make up my mind about the urgency of the fix. > > Ah, okay. The probability of a user hitting this depends on how likely > they are to perform completion inside a declare form. This depends on > the kind of code the user writes, so it's hard to put a number on it. > Also, if the user has a package like company enabled that performs > completion during idle time, then just moving point through a declare > form should be enough to trigger it, so in this case it might depend > also on the kind of code the user reads. If the user never opens an > elisp file with declare forms, then they certainly won't hit this. > > Once the user has triggered the problem via completion, all > compilation of defuns (e.g. during package installation/upgrade) with > declare forms will be broken (as well as loading uncompiled defuns > with declare forms). Admittedly only gv-expander (along with > gv-setter, but that one doesn't get unlearned) is vital to correct > compilation, the rest (advertised-calling-convention obsolete > interactive-only pure side-effect-free compiler-macro doc-string > indent) are only optimizations or advisory in nature. OK, let's push to emacs-25. Thanks.