From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: michael_heerdegen@web.de, 23648@debbugs.gnu.org, pogonyshev@gmail.com
Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified
Date: Sat, 23 Jul 2016 11:54:47 +0300 [thread overview]
Message-ID: <834m7gwx7s.fsf@gnu.org> (raw)
In-Reply-To: <CAM-tV--KuVmqhb_iEt3Pwfpa9awwQAQ2mL8E+mNRDsjcexiqYA@mail.gmail.com> (message from Noam Postavsky on Thu, 21 Jul 2016 17:27:49 -0400)
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Thu, 21 Jul 2016 17:27:49 -0400
> Cc: Michael Heerdegen <michael_heerdegen@web.de>, 23648@debbugs.gnu.org,
> Paul Pogonyshev <pogonyshev@gmail.com>
>
> > So I'm still looking for the answer to the "how probable" question. I
> > need that to make up my mind about the urgency of the fix.
>
> Ah, okay. The probability of a user hitting this depends on how likely
> they are to perform completion inside a declare form. This depends on
> the kind of code the user writes, so it's hard to put a number on it.
> Also, if the user has a package like company enabled that performs
> completion during idle time, then just moving point through a declare
> form should be enough to trigger it, so in this case it might depend
> also on the kind of code the user reads. If the user never opens an
> elisp file with declare forms, then they certainly won't hit this.
>
> Once the user has triggered the problem via completion, all
> compilation of defuns (e.g. during package installation/upgrade) with
> declare forms will be broken (as well as loading uncompiled defuns
> with declare forms). Admittedly only gv-expander (along with
> gv-setter, but that one doesn't get unlearned) is vital to correct
> compilation, the rest (advertised-calling-convention obsolete
> interactive-only pure side-effect-free compiler-macro doc-string
> indent) are only optimizations or advisory in nature.
OK, let's push to emacs-25. Thanks.
next prev parent reply other threads:[~2016-07-23 8:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-29 14:11 bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Paul Pogonyshev
2016-07-18 3:00 ` npostavs
2016-07-18 14:33 ` Eli Zaretskii
2016-07-18 15:53 ` Noam Postavsky
2016-07-18 18:16 ` Eli Zaretskii
2016-07-18 18:58 ` Noam Postavsky
2016-07-18 19:08 ` Eli Zaretskii
2016-07-18 21:28 ` Michael Heerdegen
2016-07-19 2:40 ` Eli Zaretskii
2016-07-21 1:09 ` npostavs
2016-07-21 14:22 ` Eli Zaretskii
2016-07-21 21:27 ` Noam Postavsky
2016-07-23 8:54 ` Eli Zaretskii [this message]
2016-07-23 14:18 ` npostavs
2016-07-24 17:07 ` Paul Pogonyshev
2016-07-24 17:31 ` Eli Zaretskii
2016-07-18 19:17 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834m7gwx7s.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=23648@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=npostavs@users.sourceforge.net \
--cc=pogonyshev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.